Add warning for overlapping highlights #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
approved these changes
Apr 9, 2024
Malar-Natarajan
temporarily deployed
to
rex-web-add-warning-for-hj7p2f
Malar-Natarajan
temporarily deployed
to
rex-web-add-warning-for-sjgvs5
RoyEJohnson
force-pushed
the
add-warning-for-overlapping-highlights
branch
from
cf0eb83 to
4a249fd
Compare
RoyEJohnson
force-pushed
the
add-warning-for-overlapping-highlights
branch
from
e68873d to
da7c608
Compare
RoyEJohnson
force-pushed
the
add-warning-for-overlapping-highlights
branch
from
da7c608 to
f73b598
Compare
RoyEJohnson
commented
May 9, 2024
| @@ -125,6 +125,7 @@ | |||
| "i18n:notification:toast:highlights:popup:load-failure": "No se pudo cargar algunos textos resaltados. Por favor, compruebe su conexión y vuelva a intentarlo.", | |||
| "i18n:notification:toast:highlights:popup:print-failure": "No podemos imprimir esta página. Por favor, compruebe su conexión y vuelva a intentarlo.", | |||
| "i18n:notification:toast:study-guides:load-failure": "No podemos cargar las guías de estudio en esta página. Por favor, compruebe su conexión y vuelva a intentarlo.", | |||
| "i18n:notification:toast:highlights:select-overlap": "No se admiten resaltados superpuestos.", | |||
There was a problem hiding this comment.
@bethshook Can you check this translation, please?
RoyEJohnson
commented
May 9, 2024
src/app/messages/pl/messages.json
Outdated
| @@ -125,6 +125,7 @@ | |||
| "i18n:notification:toast:highlights:popup:load-failure": "Niektóre zakreślenia na tej stronie nie mogą zostać załadowane. Sprawdź połączenie z internetem i spróbuj ponownie.", | |||
| "i18n:notification:toast:highlights:popup:print-failure": "Nie możemy wydrukować tej strony. Sprawdź połączenie z internetem i spróbuj ponownie.", | |||
| "i18n:notification:toast:study-guides:load-failure": "Nie możemy załadować zawartości Kompendium na tej stronie. Sprawdź połączenie z internetem i spróbuj ponownie.", | |||
| "i18n:notification:toast:highlights:select-overlap": "Nakładające się podświetlenia nie są obsługiwane.", | |||
There was a problem hiding this comment.
@paulinaszczucinska Can you check this translation of "Overlapping highlights are not supported" ?
There was a problem hiding this comment.
Sure @RoyEJohnson, it would be: "Nakładające się zaznaczenia nie są obsługiwane."
RoyEJohnson
force-pushed
the
add-warning-for-overlapping-highlights
branch
from
f73b598 to
d35ea7e
Compare
|
@RoyEJohnson The unit tests are failing in this PR. Could you please have a look |
RoyEJohnson
force-pushed
the
add-warning-for-overlapping-highlights
branch
from
ccd3805 to
c3e771a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCO-49