-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch tls certs for redis and memcached #269
Conversation
e0b3b46
to
968a83a
Compare
By adding the hash of the certificate to the statefulset we react to certificate changes. Let's also take the chance to remove pkg/redis/deployment (unused).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
the memcached deployment now has the expected CONFIG_HASH env var
Containers:
memcached:
Container ID: cri-o://7bde648dcc0ccf306b39e06c3702d3572d855b13b92b7a2a7abd1489930a4460
Image: quay.io/podified-antelope-centos9/openstack-memcached@sha256:07842c4950027d42a456e7dbd474c4af6a9771bb5d50f8133508328154131308
Image ID: quay.io/podified-antelope-centos9/openstack-memcached@sha256:07842c4950027d42a456e7dbd474c4af6a9771bb5d50f8133508328154131308
Ports: 11211/TCP, 11212/TCP
Host Ports: 0/TCP, 0/TCP
Command:
/usr/bin/dumb-init
--
/usr/local/bin/kolla_start
State: Running
Started: Mon, 09 Sep 2024 07:23:39 +0000
Ready: True
Restart Count: 0
Liveness: tcp-socket :11211 delay=3s timeout=5s period=3s #success=1 #failure=3
Readiness: tcp-socket :11211 delay=5s timeout=5s period=5s #success=1 #failure=3
Environment:
KOLLA_CONFIG_STRATEGY: COPY_ALWAYS
POD_IPS: (v1:status.podIPs)
CONFIG_HASH: n5d4h68ch8ch7ch67dh5c5h686h66h67fh694hf8hbch5bchb7h687hfh5bfh5bdh656h57ch668hb4h5b9h5d5hc8h56dh558h58ch5f9h68ch55bh86q
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/infra-operator-build-deploy-kuttl |
@stuggi: Overrode contexts on behalf of stuggi: ci/prow/infra-operator-build-deploy-kuttl In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lmiccini: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
By adding the hash of the certificate to the statefulset we react to certificate changes.
Let's also take the chance to remove pkg/redis/deployment (unused).