Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch tls certs for redis and memcached #269

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

lmiccini
Copy link
Contributor

@lmiccini lmiccini commented Sep 9, 2024

By adding the hash of the certificate to the statefulset we react to certificate changes.

Let's also take the chance to remove pkg/redis/deployment (unused).

By adding the hash of the certificate to the statefulset we react
to certificate changes.

Let's also take the chance to remove pkg/redis/deployment (unused).
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

the memcached deployment now has the expected CONFIG_HASH env var

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_infra-operator/269/pull-ci-openstack-k8s-operators-infra-operator-main-infra-operator-build-deploy-kuttl/1833030539049701376/artifacts/infra-operator-build-deploy-kuttl/openstack-k8s-operators-gather/artifacts/must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-211f90ff2d5a288b456ac8666f2a46280f4e5035fe6c304d3aab966ac9659fff/namespaces/openstack/pods/memcached-0/memcached-0-describe

Containers:
memcached:
Container ID: cri-o://7bde648dcc0ccf306b39e06c3702d3572d855b13b92b7a2a7abd1489930a4460
Image: quay.io/podified-antelope-centos9/openstack-memcached@sha256:07842c4950027d42a456e7dbd474c4af6a9771bb5d50f8133508328154131308
Image ID: quay.io/podified-antelope-centos9/openstack-memcached@sha256:07842c4950027d42a456e7dbd474c4af6a9771bb5d50f8133508328154131308
Ports: 11211/TCP, 11212/TCP
Host Ports: 0/TCP, 0/TCP
Command:
/usr/bin/dumb-init
--
/usr/local/bin/kolla_start
State: Running
Started: Mon, 09 Sep 2024 07:23:39 +0000
Ready: True
Restart Count: 0
Liveness: tcp-socket :11211 delay=3s timeout=5s period=3s #success=1 #failure=3
Readiness: tcp-socket :11211 delay=5s timeout=5s period=5s #success=1 #failure=3
Environment:
KOLLA_CONFIG_STRATEGY: COPY_ALWAYS
POD_IPS: (v1:status.podIPs)
CONFIG_HASH: n5d4h68ch8ch7ch67dh5c5h686h66h67fh694hf8hbch5bchb7h687hfh5bfh5bdh656h57ch668hb4h5b9h5d5hc8h56dh558h58ch5f9h68ch55bh86q

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 9, 2024
@stuggi
Copy link
Contributor

stuggi commented Sep 9, 2024

/override ci/prow/infra-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/infra-operator-build-deploy-kuttl

In response to this:

/override ci/prow/infra-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lmiccini lmiccini merged commit 1c6c4ff into openstack-k8s-operators:main Sep 9, 2024
7 checks passed
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/infra-operator-build-deploy-kuttl 968a83a link unknown /test infra-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants