From 4256e65adae66f0df2b3a94903ce9604af06ba7c Mon Sep 17 00:00:00 2001
From: Tom Weininger <tweining@redhat.com>
Date: Tue, 5 Nov 2024 14:38:01 +0100
Subject: [PATCH] Octavia data plane adoption

Documentation for adopting the data plane, ie. amphorae,
specifically.
---
 .../assembly_adopting-the-data-plane.adoc     |  2 +
 .../proc_adopting-octavia-amphorae.adoc       | 37 +++++++++++++++++++
 ...roc_adopting-the-loadbalancer-service.adoc | 16 ++------
 3 files changed, 43 insertions(+), 12 deletions(-)
 create mode 100644 docs_user/modules/proc_adopting-octavia-amphorae.adoc

diff --git a/docs_user/assemblies/assembly_adopting-the-data-plane.adoc b/docs_user/assemblies/assembly_adopting-the-data-plane.adoc
index 39c1494d2..5162e0ee9 100644
--- a/docs_user/assemblies/assembly_adopting-the-data-plane.adoc
+++ b/docs_user/assemblies/assembly_adopting-the-data-plane.adoc
@@ -24,5 +24,7 @@ include::../modules/proc_performing-a-fast-forward-upgrade-on-compute-services.a
 
 include::../modules/proc_adopting-networker-services-to-the-data-plane.adoc[leveloffset=+1]
 
+include::../modules/proc_adopting-octavia-amphorae.adoc[leveloffset=+1]
+
 ifdef::parent-context[:context: {parent-context}]
 ifndef::parent-context[:!context:]
diff --git a/docs_user/modules/proc_adopting-octavia-amphorae.adoc b/docs_user/modules/proc_adopting-octavia-amphorae.adoc
new file mode 100644
index 000000000..33002144a
--- /dev/null
+++ b/docs_user/modules/proc_adopting-octavia-amphorae.adoc
@@ -0,0 +1,37 @@
+[id="adopting-octavia-amphorae_{context}"]
+
+= {loadbalancer_service} data plane adoption
+At this point all services on the new control plane should be running except
+the {loadbalancer_service} services
+
+== Clean up old neutron ports
+This deletes the old management port.
+
+[source,bash]
+----
+HM_PORTID="$(openstack port list --device-owner Octavia:health-mgr -f value -c ID)"
+openstack port delete "$HM_PORTID"
+----
+
+== Enabling the {loadbalancer_service} in OpenShift
+Run the following command in order to enable the {loadbalancer_service} CR
+and to finish the adoption process for {loadbalancer_service}.
+
+[source,bash]
+----
+oc patch openstackcontrolplane openstack --type=merge --patch '
+spec:
+  octavia:
+    enabled: true
+    template: {}
+'
+----
+
+[NOTE]
+====
+Because no heartbeats from the amphorae were recorded in the database since
+the {loadbalancer_service} services were stopped at the beginning of
+the adoption process all amphorae will get failed over by the new control
+plane. This process ensures that amphorae get updated to using the new
+amphora image.
+====
diff --git a/docs_user/modules/proc_adopting-the-loadbalancer-service.adoc b/docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
index 483519253..8624a5c17 100644
--- a/docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
+++ b/docs_user/modules/proc_adopting-the-loadbalancer-service.adoc
@@ -29,15 +29,7 @@ These commands convert the existing single CA configuration into a dual CA confi
 // == TODO: Other things
 // TODO
 
-== Enabling the {loadbalancer_service} in OpenShift
-Run the following command in order to enable the {loadbalancer_service} CR.
-
-[source,bash]
-----
-$ oc patch openstackcontrolplane openstack --type=merge --patch '
-spec:
-  octavia:
-    enabled: true
-    template: {}
-'
-----
+== Final steps
+Octavia services must remain disabled until data plane adoption is finished in
+order to avoid amphora failovers before the data plane adoption steps were
+finished.