Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add ability to search/filter #61

Open
TeresaP opened this issue May 24, 2022 · 7 comments
Open

[REQUEST] Add ability to search/filter #61

TeresaP opened this issue May 24, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TeresaP
Copy link

TeresaP commented May 24, 2022

It would be great to add the ability to search stories based on keywords or filter based on topics. As the number of stories grow, it will be more challenging to reach chronologically older content, so having a way to surface those stories would be helpful.

@TeresaP TeresaP added the enhancement New feature or request label May 24, 2022
@juliaferraioli
Copy link
Member

Great suggestion! Search or a list of most commonly used tags would be fantastic. Thanks @TeresaP! I probably won't take this on immediately, in case someone wants to make this their first contribution to the project.

@juliaferraioli juliaferraioli added the good first issue Good for newcomers label May 25, 2022
@juliaferraioli
Copy link
Member

@all-contributors please add @TeresaP for ideas!

@allcontributors
Copy link
Contributor

@juliaferraioli

I've put up a pull request to add @TeresaP! 🎉

@ApurvaBasule
Copy link

@juliaferraioli can i work on this issue?

@juliaferraioli
Copy link
Member

@ApurvaBasule absolutely! There are at least two potential approaches:

  1. add a link to https://www.opensourcestories.org/tags/ to the menu (good first step, probably not ideal)
  2. customize a new list.html in the layouts/stories directory that displays the top n tags alongside the list of stories

Search would be a more advanced effort, but you're welcome to research that if you like!

Let me know if you have any questions.

@LuvvAggarwal
Copy link
Contributor

Hey, I have worked on this issue and created a new PR as I thought it is pending
@juliaferraioli is it fine or against contribution guideline?

@juliaferraioli
Copy link
Member

juliaferraioli commented Jun 18, 2023

Hi @LuvvAggarwal, please see my previous comment as to the approach we're looking for. And in the future, if an issue is already assigned, please ask if you can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants