Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

> 另外我感覺mapByPartition的設計似乎缺少明確的意義，它似乎只是一個劣化版的mapByReplica，不如把它修改成回傳leader partition 或者直接移除。 #582

Closed
chia7712 opened this issue Aug 12, 2022 · 3 comments
Closed

> 另外我感覺mapByPartition的設計似乎缺少明確的意義，它似乎只是一個劣化版的mapByReplica，不如把它修改成回傳leader partition 或者直接移除。 #582

chia7712 opened this issue Aug 12, 2022 · 3 comments

Comments

@chia7712
Copy link
Contributor

另外我感覺mapByPartition的設計似乎缺少明確的意義，它似乎只是一個劣化版的mapByReplica，不如把它修改成回傳leader partition 或者直接移除。

同意，mapByPartition似乎可以被mapByReplica所取代

@qoo332001 你覺得呢？

Originally posted by @chia7712 in #569 (comment)
@qoo332001
Copy link
Collaborator

好的，我開一隻PR處理，把回傳的replica改回只回傳leader

@chia7712
Copy link
Contributor Author

我開一隻PR處理，把回傳的replica改回只回傳leader

我倒是覺得移除比較好，畢竟mapByReplica應該在做cost使用時更適合，因為它帶有節點的資訊。還是說mapByPartition有特定的用途嗎？

@qoo332001
Copy link
Collaborator

還是說mapByPartition有特定的用途嗎？

目前確實是沒有用到mapByPartition的地方，那我先拿掉好了

@qoo332001 qoo332001 mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chia7712 @qoo332001