Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Feature from setup.py #80

Closed
sikuan opened this issue May 5, 2020 · 9 comments
Closed

Remove Feature from setup.py #80

sikuan opened this issue May 5, 2020 · 9 comments
Labels

Comments

@sikuan
Copy link

sikuan commented May 5, 2020

Hi,

from setuptools 46.0, Feature support was completely removed: pypa/setuptools@c719690 and pypa/setuptools#1979.

There are some Feature usages in this module:

from setuptools import setup, Extension, Feature

'performance': Feature(

So suppose these should be removed. Thanks.

@alessiamarcolini
Copy link

Dear everyone, as a gesture of courtesy towards the community, we forked the openslide-python repo and we released it on PyPI. Please note that this is a temporary workaround to have openslide-python installable via pip without the setuptools issue.

https://pypi.org/project/openslide-wrapper/1.1.2/

cc @ernestoarbitrio and @nicolebussola

@PiRK
Copy link

PiRK commented Jun 28, 2020

I made a patch in a repository I cloned manually, before realizing that there was already an openslide-python repo on github.
PiRK/openslide@c11b26a

It works for me, but I don't really understand what Feature was used for. I hope my change didn't break anything else.

Should I try to submit a pull request with my patch?

@keeganwitt
Copy link

Related MR: #76.

@c-arthurs
Copy link

I think this is what was causing me to get the ImportError: cannot import name 'Feature' from 'setuptools' error when installing openslide-python.
Obviously not a permanent fix but downgrading the setuptools to 45 will let you install openslide-python:
pip install setuptools==45

@ericmjl
Copy link

ericmjl commented Aug 12, 2020

Hello friends! I have a colleague who ran into the same set of issues here. I do see that the source code on the latest master branch is up-to-date, and doesn't use Feature in setup.py. Would there be a possibility of cutting a patch release on PyPI, to make installation easier for all users please? tagging @hugovk and @bgilbert, who are (I think) the biggest code contributors here. Given that the package is up on PyPI, I hope it won't be too big of a burden for you two!

@hugovk
Copy link
Contributor

hugovk commented Aug 12, 2020

Hello! I'm just an occasional contributor and don't have merge or release rights for this repo.

@bgilbert is listed as maintainer on https://pypi.org/project/openslide-python/ and hopefully can make a release soon!

@paul-english
Copy link

This is pretty old for a really minor issue that totally blocks most new installs. @bgilbert can we get a release to fix this, or add more maintainers to this repo?

@bgilbert
Copy link
Member

Yup, we'll get a new release out soon.

@bgilbert
Copy link
Member

OpenSlide Python 1.1.2 has been released with a fix for this issue. Thanks for your patience and persistence, all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

9 participants