Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove default timeout in shutdown? #332

Open
Peque opened this issue Jun 26, 2019 · 0 comments
Open

Should we remove default timeout in shutdown? #332

Peque opened this issue Jun 26, 2019 · 0 comments
Assignees
Milestone

Comments

@Peque
Copy link
Member

Peque commented Jun 26, 2019

Following the "explicit is better than implicit" mantra maybe we should remove the default value of 10., which is pretty arbitrary.

Maybe the shutdown call should wait forever unless a timeout is provided.

Maybe we should split the current shutdown-related methods into:

  • .shutdown(): 100% clean shutdown, optional timeout which raises an exception
  • .kill(): 0% clean shutdown, optional timeout which raises an exception
  • .terminate(): similar to what we currently have, which tries to shutdown for a while and if that does not succeed, it tries to kill; timeout is not optional (and will raise an exception if reached)

Properly implemented agents should be able to .shutdown() cleanly and maybe the most intuitive behavior is for the system to wait until that happens (even if it takes longer than 10 seconds or any other arbitrary timeout).

@Peque Peque added this to the 0.7.0 milestone Jun 26, 2019
@Peque Peque self-assigned this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant