Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: add 4.18 merge-bot jobs #59117

Merged
merged 1 commit into from
Nov 25, 2024
Merged

openstack: add 4.18 merge-bot jobs #59117

merged 1 commit into from
Nov 25, 2024

Conversation

EmilienM
Copy link
Member

  • Add 4.18 jobs for merge-bot on CPO and CAPO.
  • Add the new CLI option to run make on CAPO merge for main and 4.18.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@EmilienM, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 72ee8a4be31c4706eddd904044848bbf097acc22]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

mandre
mandre reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Let's wait for 4.18 no longer being sync'ed with master before merging.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@EmilienM
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 22, 2024
@EmilienM
Copy link
Member Author

oops I found an issue in the job name

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 22, 2024
@openshift-ci-robot
Copy link
Contributor

@EmilienM: job(s): periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18 either don't exist or were not found to be affected, and cannot be rehearsed

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@EmilienM: job(s): periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18 either don't exist or were not found to be affected, and cannot be rehearsed

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@EmilienM: job(s): periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18 either don't exist or were not found to be affected, and cannot be rehearsed

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4-18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Member Author

🤦‍♂️ wrong name

@EmilienM
Copy link
Member Author

@mandre I think the error is expected?

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cloud-provider-openstack-4-18

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 23, 2024 •
edited
Loading

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18 07d3172 link unknown /pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4.18
ci/rehearse/periodic-ci-shiftstack-merge-bot-main-cloud-provider-openstack-4-18 587325f link unknown /pj-rehearse periodic-ci-shiftstack-merge-bot-main-cloud-provider-openstack-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 23, 2024
@EmilienM
Copy link
Member Author

/pj-rehearse abort
an issue with Containerfile.

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Member Author

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
openstack: add 4.18 merge-bot jobs
99fe66d 
* Add 4.18 jobs for merge-bot on CPO and CAPO.
* Add the new CLI option to run make on CAPO merge for main and 4.18.
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4-18

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-main N/A periodic Ci-operator config changed
periodic-ci-shiftstack-merge-bot-main-cluster-api-provider-openstack-4-18 N/A periodic Periodic changed
periodic-ci-shiftstack-merge-bot-main-cloud-provider-openstack-4-18 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 24, 2024
@EmilienM
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 24, 2024
@EmilienM EmilienM requested a review from mandre November 24, 2024 21:18
@EmilienM
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2024
@mandre
Copy link
Member

mandre commented Nov 25, 2024

My comment from #59117 (review) still holds as far as I can tell.
/hold

@EmilienM
Copy link
Member Author

Branching just finished, I think we can have it now.

@EmilienM EmilienM mentioned this pull request Nov 25, 2024
Open
mandre
mandre reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e9b7aaa into openshift:master Nov 25, 2024
16 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the capo-make branch November 25, 2024 16:36
mpkredhat pushed a commit to mpkredhat/release that referenced this pull request Nov 26, 2024
@EmilienM @mpkredhat
openstack: add 4.18 merge-bot jobs (openshift#59117)
bb8528b 
* Add 4.18 jobs for merge-bot on CPO and CAPO.
* Add the new CLI option to run make on CAPO merge for main and 4.18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilienM @openshift-ci-robot @mandre