Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition Kernel Argument Support #503

Open
arithx opened this issue Feb 23, 2021 · 2 comments
Open

Ignition Kernel Argument Support #503

arithx opened this issue Feb 23, 2021 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@arithx
Copy link
Contributor

arithx commented Feb 23, 2021

Overview

Ignition is planning to add kernel argument support (coreos/ignition#1168), the base CoreOS distribution implementation design discussion (coreos/fedora-coreos-tracker#752) will handle the general case however there are likely additional integration points with RHCOS & the MCO that would likely make sense.

FIPS

RHCOS Side

Ignition expects that the system is being rebooted once kernel arguments have been applied. This stage will likely run in between the fetch & disks Ignition stages and has some similarities with the FIPS script. At minimum we'll need to coordinate the two so that there is a maximum of one reboot in the initrd (if any of FIPS or Ignition kernel arguments are set).

It is probably worth looking into if there's an easy way to remove the current FIPS code and perform the same action via a generated Ignition config. If so then we could tie that in with the approach detailed in the MCS section.

MCS Side

When the fips flag is set inside of a MachineConfig the MCS could be updated to serve a modified Ignition config containing the desired kernel arguments, files, systemd units, etc. when the requesting caller is using a relevant version of Ignition (e.x. only for Ignition 3.3.0 callers). This would allow us to drop the encapsulated machine config on newer bootimages and just read the Ignition config.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@travier
Copy link
Member

travier commented Jun 7, 2021

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants