Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc: better new-app suggestions #8021

Merged
merged 1 commit into from
Mar 17, 2016
Merged

oc: better new-app suggestions #8021

merged 1 commit into from
Mar 17, 2016

Conversation

0xmichalis
Copy link
Contributor

@@ -286,9 +286,9 @@ func RunNewApplication(fullName string, f *clientcmd.Factory, out io.Writer, c *
}
}
if triggered {
fmt.Fprintf(out, "%sBuild scheduled for %q, use 'oc logs' to track its progress.\n", indent, t.Name)
fmt.Fprintf(out, "%sBuild scheduled for %q, use 'oc logs -f bc/%s' to track its progress.\n", indent, t.Name, t.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is redundant, just say "build scheduled, use 'oc logs -f bc/%s'"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c82d9f5

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2150/)

@0xmichalis
Copy link
Contributor Author

[merge]

@0xmichalis
Copy link
Contributor Author

failure: #8039

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5345/) (Image: devenv-rhel7_3748)

@smarterclayton
Copy link
Contributor

[merge]

On Wed, Mar 16, 2016 at 2:45 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge ABORTED (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5336/
)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8021 (comment)

@0xmichalis
Copy link
Contributor Author

@smarterclayton pretty sure @liggitt aborted this for the rebase. Shouldn't we wait?

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c82d9f5

@0xmichalis
Copy link
Contributor Author

@smarterclayton pretty sure @liggitt aborted this for the rebase. Shouldn't we wait?

oh, the rebase just landed, nvmd

openshift-bot pushed a commit that referenced this pull request Mar 17, 2016
@openshift-bot openshift-bot merged commit b2e833a into openshift:master Mar 17, 2016
@0xmichalis 0xmichalis deleted the better-new-app-suggestion branch March 17, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants