Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oc export functionality on the server #8459

Open
0xmichalis opened this issue Apr 11, 2016 · 7 comments
Open

Move oc export functionality on the server #8459

0xmichalis opened this issue Apr 11, 2016 · 7 comments
Assignees
Labels
component/restapi kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P2 sig/master

Comments

@0xmichalis
Copy link
Contributor

Forked from #8448 (comment)

cc: @smarterclayton @deads2k

@0xmichalis
Copy link
Contributor Author

Does this mean that we should deprecate oc export in favor of oc get --export or should we update the former (at least for now)?

cc: @fabianofranz

@smarterclayton
Copy link
Contributor

oc export has other uses - I don't think oc get --export is enough, or even
solves 80% of the problem. The problem with export is that it can't deal
with multiple conditions.

On Mon, Apr 11, 2016 at 10:36 AM, Michail Kargakis <[email protected]

wrote:

Does this mean that we should deprecate oc export in favor of oc get
--export or should we update the former (at least for now)?

cc: @fabianofranz https://github.com/fabianofranz


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8459 (comment)

@deads2k
Copy link
Contributor

deads2k commented Apr 11, 2016

The problem with export is that it can't deal
with multiple conditions.

Can you elaborate on this? Which conditions are you thinking about?

@smarterclayton
Copy link
Contributor

Generally it's "is this for this cluster, or another cluster"? As well as
"is this a 'locked' version or a development copy"?

For instance, what happens when I export an image stream? Do you want to
export spec tags that point to exact images (by UID)? Export spec tags
that point to the original upstream and schedule their import? Do you want
to export a deployment config with triggers? Without triggers? Route
exporting is broken if you export to another cluster (since spec.host is
defaulted by the server but we can't tell whether the end user intended it
to be set, so it's hard to say whether it can be exported across.

On Mon, Apr 11, 2016 at 11:10 AM, David Eads [email protected]
wrote:

The problem with export is that it can't deal
with multiple conditions.

Can you elaborate on this? Which conditions are you thinking about?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8459 (comment)

@deads2k
Copy link
Contributor

deads2k commented Apr 11, 2016

@smarterclayton ok, so the objection is to the lack of expressive-ness in a boolean flag, not to the idea (pushed upstream) of moving export logic server-side to avoid lots of a client-side logic.

I think I'd want the boolean flag to cleanly handle a case of oc get --export all -n source -o yaml | oc create -n destination -f -.

@0xmichalis
Copy link
Contributor Author

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 2, 2018
@0xmichalis
Copy link
Contributor Author

/sig master

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement labels Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/restapi kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P2 sig/master
Projects
None yet
Development

No branches or pull requests

7 participants