Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SCC int/int64 types #6850

Closed
liggitt opened this issue Jan 27, 2016 · 6 comments
Closed

Change SCC int/int64 types #6850

liggitt opened this issue Jan 27, 2016 · 6 comments
Assignees
Labels
area/techdebt component/auth lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2

Comments

@liggitt
Copy link
Contributor

liggitt commented Jan 27, 2016

Because of issues with int overflow, upstream has changed int->int32, and squashed int64 to int32 in conversion. SCC types need to be updated to match this.

@mfojtik
Copy link
Contributor

mfojtik commented Sep 21, 2016

@pweil- @liggitt is this still valid? (this issue is now +6months old)

@pweil-
Copy link
Contributor

pweil- commented Sep 21, 2016

need to make sure that the strategies that have options of int64 datatype are being squashed in conversion. I don't think there are any ints left

@mfojtik mfojtik assigned php-coder and unassigned mfojtik Nov 10, 2016
@mfojtik
Copy link
Contributor

mfojtik commented Nov 10, 2016

@php-coder can you do a quick sweep to make sure that all strategies use int64 now? (they should, just need confirmation)

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2018
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/techdebt component/auth lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Projects
None yet
Development

No branches or pull requests

8 participants