Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --nowait/--timeout to logs #5584

Closed
0xmichalis opened this issue Nov 2, 2015 · 6 comments
Closed

Add --nowait/--timeout to logs #5584

0xmichalis opened this issue Nov 2, 2015 · 6 comments
Assignees
Labels
component/logging lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3

Comments

@0xmichalis
Copy link
Contributor

tbh I don't see any value in --nowait or why someone would use it but anyway since it is supported by build-logs and all of the machinery is in place, we should probably add it.

@smarterclayton
Copy link
Contributor

NoWait exists because clients may very well not want to wait for logs to be available - if something hasn't started, the effective log output is nothing.

@0xmichalis
Copy link
Contributor Author

How about making the default timeout configurable instead? --timeout=0 would equal to --nowait, plus I can now specify how much I want to wait (more or less than the default 10s we currently have for builds and deployments).

@smarterclayton
Copy link
Contributor

Making it configurable isn't unreasonable, but waiting on the server side is generally bad and is only for naive clients. It has to be upper bounded with something for admin control.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2018
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/logging lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3
Projects
None yet
Development

No branches or pull requests

6 participants