-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --nowait/--timeout to logs #5584
Comments
NoWait exists because clients may very well not want to wait for logs to be available - if something hasn't started, the effective log output is nothing. |
How about making the default timeout configurable instead? --timeout=0 would equal to --nowait, plus I can now specify how much I want to wait (more or less than the default 10s we currently have for builds and deployments). |
Making it configurable isn't unreasonable, but waiting on the server side is generally bad and is only for naive clients. It has to be upper bounded with something for admin control. |
Issues go stale after 90d of inactivity. /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
tbh I don't see any value in
--nowait
or why someone would use it but anyway since it is supported bybuild-logs
and all of the machinery is in place, we should probably add it.The text was updated successfully, but these errors were encountered: