Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image stream status tags no longer sorted newest first #17552

Closed
spadgett opened this issue Dec 1, 2017 · 3 comments
Closed

Image stream status tags no longer sorted newest first #17552

spadgett opened this issue Dec 1, 2017 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@spadgett
Copy link
Member

spadgett commented Dec 1, 2017

The web console relies on the server sorting the image stream status tags according to semver so that we can show the newest first in the UI. The tags no longer seem to be sorted in that order.

See

openshift/origin-web-catalog#573
openshift/origin-web-console#302

Version

oc v3.8.0-alpha.0+24cf6b7-321
kubernetes v1.8.1+0d5291c
features: Basic-Auth

Server https://127.0.0.1:8443
openshift v3.8.0-alpha.0+33c21b7-276
kubernetes v1.8.1+0d5291c

Steps To Reproduce

Run

$ oc get -o yaml is/nodejs -n openshift
Current Result

The status tags are not sorted newest first.

Expected Result

The status tags for nodejs should be sorted 6, 4, 0.10.

cc @bparees @miminar

@miminar
Copy link

miminar commented Dec 1, 2017

Why is it a responsibility of master API to return an array which is actually a serialized map (inherently unsorted) sorted?

This functionality isn't documented anywhere. It's the client's responsibility to sort items according to its liking - different client may have different sorting preferences and master shouldn't care.

@spadgett
Copy link
Member Author

spadgett commented Dec 1, 2017

It was a change made to fix this bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1325069
#9606

We used to sort on the client. I believe it was changed to the server so we could get proper semver sorting since we don't have a client library for that.

@spadgett
Copy link
Member Author

spadgett commented Dec 1, 2017

@jwforres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Development

No branches or pull requests

3 participants