Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers/velero.go: veleroDeployment *appsv1.Deployment unused in customizeVeleroContainer #1595

Open
kaovilai opened this issue Nov 26, 2024 · 1 comment
Open

controllers/velero.go: veleroDeployment *appsv1.Deployment unused in customizeVeleroContainer #1595

kaovilai opened this issue Nov 26, 2024 · 1 comment

Comments

@kaovilai
Copy link
Member

veleroDeployment *appsv1.Deployment is unused

oadp-operator/controllers/velero.go

Line 509 in d55863c

func (r *DPAReconciler) customizeVeleroContainer(veleroDeployment *appsv1.Deployment, veleroContainer *corev1.Container, hasShortLivedCredentials bool, prometheusPort *int) error {

@kaovilai kaovilai added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 26, 2024
@mateusoliveira43
Copy link
Contributor

This the kind of thing linters should take care

This one should do the job

oadp-operator/.golangci.yaml

Line 109 in c0f2825

# - unused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaovilai @mateusoliveira43