Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create templates tests/e2e/sample-applications #1531

Open
mateusoliveira43 opened this issue Sep 26, 2024 · 2 comments
Open

Create templates tests/e2e/sample-applications #1531

mateusoliveira43 opened this issue Sep 26, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mateusoliveira43
Copy link
Contributor

To avoid duplication, we need to create OpenShift Templates for tests/e2e/sample-applications. This will also make it easier to create the applications for manual tests

Example

Today, developer must run two command to deploy an application, one to create application's PVCs (https://github.com/openshift/oadp-operator/blob/master/tests/e2e/sample-applications/mysql-persistent/pvc-twoVol/aws.yaml) and other for the other objects (https://github.com/openshift/oadp-operator/blob/master/tests/e2e/sample-applications/mysql-persistent/mysql-persistent-twovol-csi.yaml). And if developer want to use an different storageClassName, it need to manually edit the YAML files.

With OpenShift Template, it easy to create all object at once and easy modify its parameters. Example https://github.com/migtools/oadp-non-admin/blob/master/hack/samples/apps/mysql.yaml

Failed approach

Tried in #1364, but approach would make developers running it harder (they would need to change replace strings manually).

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2024
@kaovilai
Copy link
Member

Also would like sample apps to remain compatible with pure kube so that other platforms could be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants