Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nullable hack when API version upgrades #1528

Open
mateusoliveira43 opened this issue Sep 23, 2024 · 0 comments
Open

Remove nullable hack when API version upgrades #1528

mateusoliveira43 opened this issue Sep 23, 2024 · 0 comments

Comments

@mateusoliveira43
Copy link
Contributor

As described in #1261 (comment) OADP should not add nullable keys to CRDs' YAML files

Solution would be

  • remove hack from Makefile (seems the right one, as motivation was another tool that uses OADP needing that), as tried in feat: Nullable logic in code #1261
  • transform necessary fields in pointers, so they can be nil in Go (and null in YAML) (also removing hack)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant