kubeletconfig_features: fix ignition object creation #578
Conversation
FeatureGates creates a brand new ignition object, and the ignition subsystem validates the Version field is a valid Semver. This fix uses the common constructor to create a valid ignition object. This patch changes the kubelet_config_controller to make it consistent with how the featuregates constructs the ignition object.
openshift-ci-robot
added
the
size/S
|
cc @umohnani8 for container runtime stuff |
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, runcom, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
allow the installer to use the mco to distribute ssh keys. this is the first step in adding the ability to update existing ssh keys. closes installer issue openshift#578
- What I did
FeatureGates creates a brand new ignition object, and the ignition
subsystem validates the Version field is a valid Semver. This fix uses
the common constructor to create a valid ignition object.
Note: This patch also changes the kubelet_config_controller to make it consistent
with how the featuregates controller constructs the ignition object.
- How to verify it
- Description for the changelog
None