Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/asset: Rename ingress config #754

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Nov 28, 2018

  • pkg/asset/manifests/ingress.go (Generate): Rename ingress config object from "default" to "cluster".

Per openshift/cluster-openshift-apiserver-operator#63 (comment).

@ironcladlou

With this change, we have the following:

% oc get ingresses.config.openshift.io/cluster -o yaml
apiVersion: config.openshift.io/v1
kind: Ingress
metadata:
  creationTimestamp: 2018-11-28T18:40:09Z
  generation: 1
  name: cluster
  resourceVersion: "202"
  selfLink: /apis/config.openshift.io/v1/ingresses/cluster
  uid: 0898a6c8-f33d-11e8-820c-06b750ec8402
spec:
  domain: apps.mmasters.devcluster.openshift.com
status: {}
% oc get ingresses.config.openshift.io/default -o yaml
Error from server (NotFound): ingresses.config.openshift.io "default" not found

* pkg/asset/manifests/ingress.go (Generate): Rename ingress config object
from "default" to "cluster".
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2018
@ironcladlou
Copy link
Contributor

@Miciah
Copy link
Contributor Author

Miciah commented Nov 28, 2018

Correct, they will need to be amended.

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor Author

Miciah commented Nov 28, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2018

@Miciah: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9b0c84e link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b8c292e into openshift:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants