Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/data/aws/variables-aws: Drop tectonic_aws_worker_ec2_type, etc. #742

Merged
merged 2 commits into from
Nov 30, 2018
Merged

data/data/aws/variables-aws: Drop tectonic_aws_worker_ec2_type, etc. #742

merged 2 commits into from
Nov 30, 2018

Conversation

wking
Copy link
Member

@wking wking commented Nov 27, 2018

The last consumers for these were removed by 124ac35 (#119).

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2018
@wking wking mentioned this pull request Nov 27, 2018
Merged
@wking
data/data/aws/variables-aws: Drop tectonic_aws_worker_ec2_type, etc.
76b5757 
The last consumers for these were removed by 124ac35 (*: Use
machine-api-operator to deploy worker nodes, 2018-09-04, openshift#119).
@wking wking force-pushed the trim-aws-worker-terraform branch from 19beb6f to 76b5757 Compare November 27, 2018 21:15
@abhinavdahiya
Copy link
Contributor

relates to #743 can we drop worker stuff wholesale in one PR/commit. multiple PRs for same logical thing is :(

@wking
Copy link
Member Author

wking commented Nov 27, 2018 •
edited
Loading

relates to #743 can we drop worker stuff wholesale in one PR/commit.

I can pull that commit in here. I split them up because this one's clearly a no-op, while #743 changes the libvirt behavior (although hopefully not in a way that breaks the cluster).

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2018
@wking
Copy link
Member Author

wking commented Nov 27, 2018

I've pushed 76b5757 -> 2ef00f2, pulling in the commit from #743.

@wking wking mentioned this pull request Nov 27, 2018
Closed
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@wking
Copy link
Member Author

wking commented Nov 28, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@wking
data/data/config: Drop tectonic_worker_count
6ccf0f1 
And the related, libvirt-specific, tectonic_libvirt_worker_ips.  This
simplifies the Terraform logic for AWS and OpenStack, and consistently
pushes most worker setup into the cluster-API providers who are
creating the workers since 124ac35 (*: Use machine-api-operator to
deploy worker nodes, 2018-09-04, openshift#119).
@wking wking force-pushed the trim-aws-worker-terraform branch from 2ef00f2 to 6ccf0f1 Compare November 28, 2018 18:18
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@wking
Copy link
Member Author

wking commented Nov 28, 2018

I'd forgotten to drop a data.libvirt_network_dns_host_template.workers consumer. Fixed in 2ef00f2 -> 6ccf0f1.

@wking
Copy link
Member Author

wking commented Nov 28, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 6ccf0f1 link /test e2e-aws
ci/prow/e2e-libvirt 6ccf0f1 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6ccf0f1 into openshift:master Nov 30, 2018
@wking wking deleted the trim-aws-worker-terraform branch November 30, 2018 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@crawford crawford Awaiting requested review from crawford

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wking @abhinavdahiya @openshift-ci-robot @openshift-bot @crawford @openshift-merge-robot