hack: pin the release image in build flags #732
Conversation
openshift-ci-robot
added
size/S
|
@wking Review please. The default image has the 'latest' tag now. Is that okay? |
|
I am confused as to the purpose of burning an image into the binary. It might get confusing to customers which binary to use. |
We want to be able to cut releases that will install a cluster for more than a few hours (until a release image change lands that requires an associated installer update). The plan is to have master continue to float with the most current release image, but to pin to the then-current release image when we cut an installer release. So if we get this PR into |
openshift-ci-robot
added
size/XS
But still leave an override env var so that it can be overridden. Use the following env var to pin the image while building the binary: ``` $ # export the release-image variable $ export OPENSHIFT_INSTALL_RELEASE_IMAGE=registry.redhat.io/openshift/origin-release:v4.0" $ # build the openshift-install binary $ ./hack/build.sh $ # distribute the binary to customers and run with pinned image being picked up $ ./bin/openshift-install create cluster... ``` The only way to override it would be to use an env var OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE while running the openshift-install binary.
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rajatchopra: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm cancel @abhinavdahiya raised some issues with this general approach over here. I'm pulling this out of the merge queue until we find an approach we all like. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajatchopra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Closing this PR. The commit is included already in PR #757, where the OS image is being pinned also. |
But still leave an override env var so that it can be overridden. Use the following env var to pin the image while building the binary:
The only way to override it would be to use an env var OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE while running the openshift-install binary.