-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kube-dns from installer #548
Remove kube-dns from installer #548
Conversation
pravisankar
commented
Oct 26, 2018
- Now openshift-cluster-dns-operator will provide the needed internal domain resolution functionality
10bb54f
to
7ccdb3a
Compare
/retest |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
2 similar comments
/retest |
/retest |
The latest failure may not be a flake... better double check this branch against AWS and manually try the commands the CI job template is using to find the router |
4fc908b
to
0c981d3
Compare
@pravisankar it seems like these changes are causing the cluster to not come up. Finally managed to get past the nat gateway limit! Here's what I saw on one of the master nodes:
So it looks like because we disabled the dns server, the etcd setup fails and nothing starts up. |
@pravisankar aah, k I just tested directly with this branch and its rebased upto sha: |
f06ac29
to
c9daf5c
Compare
openshift/cluster-dns-operator#44 should allow the dns operator to schedule on masters. otherwise the error from ci sudo oc --config /opt/tectonic/auth/kubeconfig -n openshift-cluster-dns-operator get pods cluster-dns-operator-7cdc75466d-nksx4 -oyaml
apiVersion: v1
kind: Pod
metadata:
creationTimestamp: 2018-11-02T18:26:40Z
generateName: cluster-dns-operator-7cdc75466d-
labels:
name: cluster-dns-operator
pod-template-hash: "3787310228"
name: cluster-dns-operator-7cdc75466d-nksx4
namespace: openshift-cluster-dns-operator
ownerReferences:
- apiVersion: apps/v1
blockOwnerDeletion: true
controller: true
kind: ReplicaSet
name: cluster-dns-operator-7cdc75466d
uid: d738a17f-decc-11e8-9871-124667a4a6a6
resourceVersion: "1618"
selfLink: /api/v1/namespaces/openshift-cluster-dns-operator/pods/cluster-dns-operator-7cdc75466d-nksx4
uid: d739f920-decc-11e8-9871-124667a4a6a6
spec:
containers:
- command:
- cluster-dns-operator
env:
- name: WATCH_NAMESPACE
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
- name: OPERATOR_NAME
value: cluster-dns-operator
image: registry.svc.ci.openshift.org/ci-op-m3n2pzv1/stable@sha256:462a4ae61446e9c98f82c7d63d20d9c060a00678ec6957ddcfe83ddd31af9270
imagePullPolicy: IfNotPresent
name: cluster-dns-operator
resources: {}
terminationMessagePath: /dev/termination-log
terminationMessagePolicy: File
volumeMounts:
- mountPath: /var/run/secrets/kubernetes.io/serviceaccount
name: cluster-dns-operator-token-zqr9j
readOnly: true
dnsPolicy: Default
priority: 0
restartPolicy: Always
schedulerName: default-scheduler
securityContext: {}
serviceAccount: cluster-dns-operator
serviceAccountName: cluster-dns-operator
terminationGracePeriodSeconds: 30
volumes:
- name: cluster-dns-operator-token-zqr9j
secret:
defaultMode: 420
secretName: cluster-dns-operator-token-zqr9j
status:
conditions:
- lastProbeTime: null
lastTransitionTime: 2018-11-02T18:26:40Z
message: '0/3 nodes are available: 3 node(s) had taints that the pod didn''t tolerate.'
reason: Unschedulable
status: "False"
type: PodScheduled
phase: Pending
qosClass: BestEffort |
/retest |
@abhinavdahiya looks like this is ready to go, PTAL |
@pravisankar remove the WIP tag? |
@ironcladlou @abhinavdahiya this will break extended test, prefer this to be merged after openshift/origin#21406 (updating the pr as per the feedback) |
@pravisankar I think you have it backwards: e2e-aws passes today with this PR (wildcard extended tests aren't enabled yet in the job). This one should merge ASAP so we can start detecting and dealing with any fallout. |
@abhinavdahiya can you please review/merge this pr? |
/approve |
- Now openshift-cluster-dns-operator will provide the needed internal domain resolution functionality
c9daf5c
to
70991dd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |