Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: hide OpenStack in the list of platforms #1054

Merged
merged 1 commit into from
Jan 13, 2019
Merged

types: hide OpenStack in the list of platforms #1054

merged 1 commit into from
Jan 13, 2019

Conversation

crawford
Copy link
Contributor

Since OpenStack isn't going to be fully supported in 4.0, it needs to be
hidden to prevent users from accidentally choosing it. This still leaves
the platform prompt in the UI with just a single choice, but this is
nice because it makes it clear that more platforms will be supported by
this tool in the future.

@crawford
types: hide OpenStack in the list of platforms
877a517 
Since OpenStack isn't going to be fully supported in 4.0, it needs to be
hidden to prevent users from accidentally choosing it. This still leaves
the platform prompt in the UI with just a single choice, but this is
nice because it makes it clear that more platforms will be supported by
this tool in the future.
@crawford crawford added this to the Freeze milestone Jan 11, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2019
@staebler
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@russellb
Copy link
Member

and for the record from the OpenStack side, /lgtm

This seems like a good approach as long as it's still experimental. People can still try it via a custom install-config file, so it's no big deal.

@crawford
Copy link
Contributor Author

Failed tests:

  • [Conformance][templates] templateinstance cross-namespace test should create and delete objects across namespaces [Suite:openshift/conformance/parallel/minimal]
  • [Feature:AnnotationTrigger] Annotation trigger reconciles after the image is overwritten [Suite:openshift/conformance/parallel]
  • [Feature:DeploymentConfig] deploymentconfigs with custom deployments [Conformance] should run the custom deployment steps [Suite:openshift/conformance/parallel/minimal]

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor Author

level=fatal msg="waiting for bootstrap-complete: timed out waiting for the condition"

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor Author

level=error msg="2 errors occurred:"
level=error msg="\t* module.vpc.aws_internet_gateway.igw: 1 error occurred:"
level=error msg="\t* aws_internet_gateway.igw: error attaching EC2 Internet Gateway (igw-03a19b7f6a759238f): timeout while waiting for state to become 'success' (timeout: 2m0s)"

/retest

@crawford
Copy link
Contributor Author

Everything seems to have failed because etcd wasn't responding. (https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1054/pull-ci-openshift-installer-master-e2e-aws/2824)

/retest

@crawford
Copy link
Contributor Author

Amusing errors:

templateinstance security tests should pass security tests
fail [github.com/openshift/origin/test/extended/templates/templateinstance_security.go:276]: Expected
<bool>: false
to equal
<bool>: true

/retest

@wking
Copy link
Member

wking commented Jan 12, 2019

e2e-aws:

fail [github.com/openshift/origin/test/extended/util/cli.go:677]: Jan 12 05:33:37.176: etcdserver: request timed out

and similar, leading to:

Flaky tests:

[sig-storage] Subpath [Volume type: nfsPVC] should support file as subpath [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-storage] Subpath [Volume type: nfs] should support readOnly directory specified in the volumeMount [Suite:openshift/conformance/parallel] [Suite:k8s]

Failing tests:

[k8s.io] [sig-node] AppArmor load AppArmor profiles should enforce an AppArmor profile [Suite:openshift/conformance/parallel] [Suite:k8s]

/retest

@wking
Copy link
Member

wking commented Jan 12, 2019

e2e-aws included the osin restart:

fail [github.com/openshift/origin/test/extended/operators/cluster.go:109]: Expected
    <[]string | len:1, cap:1>: [
        "Pod openshift-core-operators/origin-cluster-osin-operator2-77cd8cb44-qwrnb is not healthy: container operator has restarted more than 5 times",
    ]
to be empty

that I suspect will be fixed by openshift/library-go#168.

/retest

@wking wking mentioned this pull request Jan 12, 2019
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor Author

More etcd unavailability issues (https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1054/pull-ci-openshift-installer-master-e2e-aws/2856).

/retest

@wking
Copy link
Member

wking commented Jan 12, 2019

e2e-aws:

Jan 12 15:36:56.181 - 299s E openshift-apiserver OpenShift API is not responding to GET requests

and more.

/retest

@crawford
Copy link
Contributor Author

More API outages due to etcd...
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1054/pull-ci-openshift-installer-master-e2e-aws/2858

/retest

@wking
Copy link
Member

wking commented Jan 12, 2019

osin panic and more.

/retest

@crawford
Copy link
Contributor Author

/retest

@wking
Copy link
Member

wking commented Jan 12, 2019

e2e-aws:

Jan 12 19:38:09.504 E openshift-apiserver OpenShift API is not responding to GET requests Jan 12 19:38:09.504 E kube-apiserver Kube API started failing: Get https://ci-op-twbnng84-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/namespaces/kube-system?timeout=3s: context deadline exceeded (Client.Timeout exceeded while awaiting headers)

and more.

/restest

@crawford
Copy link
Contributor Author

/restest

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor Author

openshift-apiserver OpenShift API is not responding to GET requests

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1f2afc7 into openshift:master Jan 13, 2019
@crawford crawford deleted the platforms branch January 13, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@russellb russellb Awaiting requested review from russellb

Assignees

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Freeze
Development

Successfully merging this pull request may close these issues.
7 participants
@crawford @staebler @openshift-ci-robot @russellb @openshift-bot @wking @openshift-merge-robot