From 4ba649b150219f8da550a314c171bcdd32f58865 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Mon, 27 Aug 2018 11:03:30 -0700 Subject: [PATCH] hack: Drop /tmp mounts Eric points out potential issues with relabeling /tmp [1], which is shared by several system-level consumers. For the Bazel script, the /tmp mount is just since c483f597 (Move bazel build tarball test to prow, 2018-08-08, #117), so we can drop it to return to our previous approach. The Terraform container seems to run fine without /tmp as well, although there's no clear history to point to on this front because we used to use Bazel for this. See b8a9bbc5 (Remove bazel from test process, 2018-08-01, #97). [1]: https://github.com/openshift/installer/pull/174#discussion_r212764528 --- hack/test-bazel-build-tarball.sh | 1 - hack/tf-fmt.sh | 1 - 2 files changed, 2 deletions(-) diff --git a/hack/test-bazel-build-tarball.sh b/hack/test-bazel-build-tarball.sh index 6e05f104311..de84fca03cb 100755 --- a/hack/test-bazel-build-tarball.sh +++ b/hack/test-bazel-build-tarball.sh @@ -6,7 +6,6 @@ else docker run --rm \ --env IS_CONTAINER=TRUE \ --volume "${PWD}:${PWD}:z" \ - --volume /tmp:/tmp:z \ --workdir "${PWD}" \ quay.io/coreos/tectonic-builder:bazel-v0.3 \ ./hack/test-bazel-build-tarball.sh diff --git a/hack/tf-fmt.sh b/hack/tf-fmt.sh index dc4f6e3b885..e9ab0659249 100755 --- a/hack/tf-fmt.sh +++ b/hack/tf-fmt.sh @@ -8,7 +8,6 @@ else docker run --rm \ --env IS_CONTAINER=TRUE \ --volume "${PWD}:${PWD}:ro,z" \ - --volume /tmp:/tmp:z \ --workdir "${PWD}" \ quay.io/coreos/terraform-alpine:v0.11.7 \ ./hack/tf-fmt.sh