Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44929: e2e: fix manila CSI operator #5186

Merged
merged 1 commit into from
Nov 26, 2024
Merged

OCPBUGS-44929: e2e: fix manila CSI operator #5186

merged 1 commit into from
Nov 26, 2024
+1 −1

Conversation

EmilienM
Copy link
Member

What this PR does / why we need it:

The name of the operator pod is manila-csi-driver-operator.
This will fix e2e for e2e-openstack.

@EmilienM
OCPBUGS-44929: e2e: fix manila CSI operator
0d1fe3c 
The name of the operator pod is `manila-csi-driver-operator`.
This will fix e2e for `e2e-openstack`.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-44929, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

The name of the operator pod is manila-csi-driver-operator.
This will fix e2e for e2e-openstack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 24, 2024
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Nov 24, 2024
@EmilienM
Copy link
Member Author

/test e2e-openstack

@EmilienM
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Member Author

/test e2e-openstack

@EmilienM
Copy link
Member Author

/test e2e-aks

@EmilienM
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

@EmilienM
Copy link
Member Author

/test e2e-aks

mandre
mandre reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EmilienM
Copy link
Member Author

/test e2e-aks

@bryan-cox
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@mandre
Copy link
Member

mandre commented Nov 25, 2024

Trying again...
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
This was referenced Nov 25, 2024
Open
Open
@EmilienM
Copy link
Member Author

/test e2e-aks

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6185030 and 2 for PR HEAD 0d1fe3c in total

@EmilienM
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6185030 and 2 for PR HEAD 0d1fe3c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2569f33 and 1 for PR HEAD 0d1fe3c in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit da24e17 into openshift:main Nov 26, 2024
17 checks passed
@openshift-ci-robot
Copy link

@EmilienM: Jira Issue OCPBUGS-44929: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44929 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

The name of the operator pod is manila-csi-driver-operator.
This will fix e2e for e2e-openstack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@EmilienM: new pull request created: #5193

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2024
Merged
@EmilienM EmilienM deleted the OCPBUGS-44929 branch November 26, 2024 14:38
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202411261738.p0.gda24e17.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EmilienM @openshift-ci-robot @openshift-cherrypick-robot @bryan-cox @mandre @openshift-bot