Change dropdown units for consistency on PVC form

[zherman0]

Change dropdown units for consistency on PVC form to shortened form

Fixes #1209

NEW:

OLD:

[spadgett]

/lgtm

[zherman0]

/retest

[zherman0]

/retest

[zherman0]

/retest

[spadgett]

@zherman0 will need #1226 to pass CI :/

[spadgett]

/retest

[AyushAmbastha]

@zherman0 @spadgett This seems to be a workaround for solving the dropdown issue as the keys are being picked up instead of the intended values from the dropdownUnits dictionary defined in 'console/frontend/public/components/storage/create-pvc.tsx'.
I've made changes to the 'console/frontend/public/components/utils/request-size-input.tsx' file which solves the problem and displays units in the shortened form.

The changes I've made are-
OLD -> this.props.onChange({ value: this.state.value, unit });
NEW -> this.props.onChange({ value: this.state.value, unit: this.state.value });

I'll open a PR if that's convenient for everyone.
Please take a look.

[spadgett]

/retest

[zherman0]

@AyushAmbastha - I am confused by your fix there.
Quoting: The changes I've made are-
OLD -> this.props.onChange({ value: this.state.value, unit });
NEW -> this.props.onChange({ value: this.state.value, unit: this.state.value });
You have set the unit state variable that is the drop down value equal to this.state.value which is the value from the numeric input field. I do not understand how this would work.

[spadgett]

/retest

[spadgett]

olm test flake

/retest

[spadgett]

/retest

[spadgett]

olm flake

/retest

[AyushAmbastha]

You have set the unit state variable that is the drop down value equal to this.state.value which is the value from the numeric input field. I do not understand how this would work.

@zherman0 Oh! I think I got confused with what 'value' is. It worked so I didn't look at it again. I'll try coming up with another fix. I feel the dictionary keys shouldn't be displayed so I don't understand why we need to define the dictionary as Mi: "Mi" and so on. It should work when the units are defined as an array as well,right?

[jhadvig]

operator-hub TC failed

/retest

[spadgett]

NoSuchElementError: No element found using locator: by.cssContainingText(".co-resource-list__item", "etcd")

/retest

[spadgett]

/retest

[spadgett]

/retest

[spadgett]

/retest

[jhadvig]

StaleElementReferenceError: stale element reference: element is not attached to the page document

/retest