Use page route instead of resource for vmtemplates

openshift · Jun 11, 2019 · b7d1a51 · b7d1a51
1 parent 3cd29c6
commit b7d1a51
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/frontend/packages/console-app/package.json b/frontend/packages/console-app/package.json
@@ -7,7 +7,8 @@
   "dependencies": {
     "@console/internal": "0.0.0-fixed",
     "@console/plugin-sdk": "0.0.0-fixed",
-    "@console/shared": "0.0.0-fixed"
+    "@console/shared": "0.0.0-fixed",
+    "@console/kubevirt-plugin": "0.0.0-fixed"
   },
   "consolePlugin": {
     "entry": "src/plugin.tsx"

diff --git a/frontend/packages/kubevirt-plugin/src/models.ts b/frontend/packages/kubevirt-plugin/src/models.ts
@@ -1,4 +1,5 @@
 import { K8sKind } from '@console/internal/module/k8s';
+import { TEMPLATE_TYPE_LABEL } from 'kubevirt-web-ui-components';
 
 export const VirtualMachineModel: K8sKind = {
   label: 'Virtual Machine',
@@ -52,7 +53,6 @@ export const VirtualMachineInstanceReplicaSetModel: K8sKind = {
   id: 'virtualmachineinstancereplicaset',
 };
 
-/* TODO(mlibra): migrate templates
 export const VmTemplateModel: K8sKind = {
   label: 'Template',
   labelPlural: 'Templates',
@@ -65,10 +65,9 @@ export const VmTemplateModel: K8sKind = {
   kind: 'Template',
   id: 'vmtemplate',
   selector: {
-    matchLabels: {[TEMPLATE_TYPE_LABEL]: 'vm'},
+    matchLabels: { [TEMPLATE_TYPE_LABEL]: 'vm' },
   },
 };
-*/
 
 export const NetworkAttachmentDefinitionModel: K8sKind = {
   label: 'Network Attachment Definition',

diff --git a/frontend/packages/kubevirt-plugin/src/plugin.ts b/frontend/packages/kubevirt-plugin/src/plugin.ts
@@ -7,6 +7,7 @@ import {
   ModelFeatureFlag,
   YAMLTemplate,
   ModelDefinition,
+  RoutePage,
 } from '@console/plugin-sdk';
 
 import * as models from './models';
@@ -18,7 +19,8 @@ type ConsumedExtensions =
   | ResourceDetailsPage
   | ModelFeatureFlag
   | YAMLTemplate
-  | ModelDefinition;
+  | ModelDefinition
+  | RoutePage;
 
 const FLAG_KUBEVIRT = 'KUBEVIRT';
 
@@ -65,6 +67,16 @@ const plugin: Plugin<ConsumedExtensions> = [
       template: yamlTemplates.getIn([models.VirtualMachineModel, 'default']),
     },
   },
+  {
+    type: 'Page/Route',
+    properties: {
+      path: `/k8s/ns/:ns/${models.VmTemplateModel.plural}`,
+      loader: () =>
+        import('./components/vm-template' /* webpackChunkName: "kubevirt-vm-template" */).then(
+          (m) => m.VirtualMachineTemplatesPage,
+        ),
+    },
+  },
   // {
   //   type: 'Page/Resource/Details',
   //   properties: {