Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCO-1443: Promote onclusterbuild to GA #2090

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Dec 5, 2024

  1. Configuration menu
    Copy the full SHA
    9d2f9ac View commit details
    Browse the repository at this point in the history
  2. Add v1 versions of OnClusterBuild APIs

    First step to GA'ing the currently v1alpha1 APIs. Don't add to payload
    manifests yet, and the featuregate is retained.
    yuqi-zhang committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    cadf259 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf08001 View commit details
    Browse the repository at this point in the history
  4. Update godoc and validation for MOSC/MOSB

    Mostly fixups, with some minor changes to the v1alpha1 API:
    
     - Removed Version and ConfigGeneration from MOSB as they were unused
     - Updated relatedobjects list
     - Changed all optional,omitempty structs to pointers
     - Removed default for ImageBuilderType, but keeping default build arch
       to noarch as we don’t foresee changing that.
     - Fixed RenderedImagePushspec validators to match description
    yuqi-zhang committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    57c2668 View commit details
    Browse the repository at this point in the history
  5. Additional fixes for MOSC/MOSB

     - Update from PodImageBuilder to JobImageBuilder, and add a
       MachineOSBuild reference to MachineOSConfig
     - Failed and Interrupted will now cause MOSBuild conditions to be
       immutable
     - Updated Arch enum to be PascalCase
     - Updated relatedObject go doc based on suggestion
     - Add validation for buildEnd > buildStart
     - Removed conditions field from MOSConfig. The build object is
       supposed to reflect conditions instead, so this is not needed
       at this time
     - Use dns1123 format check for all strings that match, and otherwise
       switch pattern checks to validation rules where appropriate
     - Updated godocs a bit more for formatting
    yuqi-zhang committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    9f4c690 View commit details
    Browse the repository at this point in the history
  6. Additional MOSC/MOSB updates

    Mostly fixes around validation and godocs. Added some additional test
    cases.
    yuqi-zhang committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    4293b4d View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2024

  1. Further MOSC/MOSB updates

     - Removed BuildOutputs and the CurrentImagePullSecret field
       (not really needed at this time, we’d prefer if the user
       would put any additional pull secrets into the cluster-wide
       object)
     - Removed BuildInputs and lifted all fields to spec, removing:
        - ReleaseVersion
        - BaseOSImagePullSpec
        - BaseOSExtensionsImagePullSpec
       Which will be populated directly from the MCO instead. We will
       consider re-adding those if there is a need for on cluster
       pre-builds off new release images in the future.
     - Renamed finalImagePushSpec to digestedImagePushSpec
     - Switched MachineOSBuilderReference back to an union, and renamed
       the job object unionmember to just “job”
     - Changed “desiredConfig” to “MachineConfig” for clarity
     - Kept ObservedGeneration, but updated the validation, and will
       fix on the MCO side
     - Removed duplicate arch types, and updated containerfiles to allow at
       most 1 per arch (minus noarch)
    yuqi-zhang committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    184fe8c View commit details
    Browse the repository at this point in the history
  2. Readd removed NodeDisruptionPolicy tests

    These were added for the alpha API originally, but they seem to have
    been removed during a refactor of the tests. The current tests are a
    duplicate of bootimage tests.
    yuqi-zhang committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    9404c51 View commit details
    Browse the repository at this point in the history