-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO-1443: Promote onclusterbuild to GA #2090
Open
yuqi-zhang
wants to merge
8
commits into
openshift:master
Choose a base branch
from
yuqi-zhang:promote-onclusterbuild
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,622
−114
Commits on Dec 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d2f9ac - Browse repository at this point
Copy the full SHA 9d2f9acView commit details -
Add v1 versions of OnClusterBuild APIs
First step to GA'ing the currently v1alpha1 APIs. Don't add to payload manifests yet, and the featuregate is retained.
Configuration menu - View commit details
-
Copy full SHA for cadf259 - Browse repository at this point
Copy the full SHA cadf259View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf08001 - Browse repository at this point
Copy the full SHA bf08001View commit details -
Update godoc and validation for MOSC/MOSB
Mostly fixups, with some minor changes to the v1alpha1 API: - Removed Version and ConfigGeneration from MOSB as they were unused - Updated relatedobjects list - Changed all optional,omitempty structs to pointers - Removed default for ImageBuilderType, but keeping default build arch to noarch as we don’t foresee changing that. - Fixed RenderedImagePushspec validators to match description
Configuration menu - View commit details
-
Copy full SHA for 57c2668 - Browse repository at this point
Copy the full SHA 57c2668View commit details -
Additional fixes for MOSC/MOSB
- Update from PodImageBuilder to JobImageBuilder, and add a MachineOSBuild reference to MachineOSConfig - Failed and Interrupted will now cause MOSBuild conditions to be immutable - Updated Arch enum to be PascalCase - Updated relatedObject go doc based on suggestion - Add validation for buildEnd > buildStart - Removed conditions field from MOSConfig. The build object is supposed to reflect conditions instead, so this is not needed at this time - Use dns1123 format check for all strings that match, and otherwise switch pattern checks to validation rules where appropriate - Updated godocs a bit more for formatting
Configuration menu - View commit details
-
Copy full SHA for 9f4c690 - Browse repository at this point
Copy the full SHA 9f4c690View commit details -
Mostly fixes around validation and godocs. Added some additional test cases.
Configuration menu - View commit details
-
Copy full SHA for 4293b4d - Browse repository at this point
Copy the full SHA 4293b4dView commit details
Commits on Dec 10, 2024
-
- Removed BuildOutputs and the CurrentImagePullSecret field (not really needed at this time, we’d prefer if the user would put any additional pull secrets into the cluster-wide object) - Removed BuildInputs and lifted all fields to spec, removing: - ReleaseVersion - BaseOSImagePullSpec - BaseOSExtensionsImagePullSpec Which will be populated directly from the MCO instead. We will consider re-adding those if there is a need for on cluster pre-builds off new release images in the future. - Renamed finalImagePushSpec to digestedImagePushSpec - Switched MachineOSBuilderReference back to an union, and renamed the job object unionmember to just “job” - Changed “desiredConfig” to “MachineConfig” for clarity - Kept ObservedGeneration, but updated the validation, and will fix on the MCO side - Removed duplicate arch types, and updated containerfiles to allow at most 1 per arch (minus noarch)
Configuration menu - View commit details
-
Copy full SHA for 184fe8c - Browse repository at this point
Copy the full SHA 184fe8cView commit details -
Readd removed NodeDisruptionPolicy tests
These were added for the alpha API originally, but they seem to have been removed during a refactor of the tests. The current tests are a duplicate of bootimage tests.
Configuration menu - View commit details
-
Copy full SHA for 9404c51 - Browse repository at this point
Copy the full SHA 9404c51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.