unbind subscriber is still deleting credentials

[maleck13]

Bug:

During unbind job we remove any credentials we stored. However this is also being done in the unbind subscriber
ubind logic https://github.com/openshift/ansible-service-broker/blob/master/pkg/broker/unbinding_subscriber.go#L89

unbind job https://github.com/openshift/ansible-service-broker/blob/master/pkg/apb/unbind.go#L74

Happy to have this assigned to me if we agree it is something that should be fixed

[shawn-hurley]

Hey,

This was supposed to moved to the APB package when we moved to secrets for extracted credentials. https://github.com/openshift/ansible-service-broker/blob/master/pkg/apb/deprovision.go#L77

In this case, I think the bug is that unbinding_subscriber should not deal with the extracted credential.

[maleck13]

ahh ok will update this issue based on that. So really the delete in the unbind subscriber should be removed