Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Provide the BareMetalMachineProviderSpec with the right fields #87

Closed
sadasu opened this issue May 22, 2019 · 2 comments · Fixed by #90
Closed

Provide the BareMetalMachineProviderSpec with the right fields #87

sadasu opened this issue May 22, 2019 · 2 comments · Fixed by #90

Comments

@sadasu
Copy link
Contributor

sadasu commented May 22, 2019

No description provided.

@russellb
Copy link
Member

As of #85 , kni-install will create the master Machines and worker MachineSet with the baremetal machine providerSpec. The next step is to populate the contents that cluster-api-provider-baremetal expects.

There are two fields that must get set in our case: the image and userdata.

Prior to having the baremetal machine providerSpec, cluster-api-provider-baremetal had the image location and the image checksum location hard coded. It will now expect to receive this in the providerSpec. It looks like the image URL is already in the install-config.yaml. The checksum is passed in as a value vs. the URL, so we may have to add a URL to the checksum as another part of the install config. See #57 for a discussion of the current install-config contents.

The other is the userdata field. Prior to this change, cluster-api-provider-baremetal assumed there would be a Secret named worker-user-data. Now it should come from the providerSpec. The installer probably knows the right name to use.

See metal3-io/cluster-api-provider-baremetal#59 for where some of this hard coded information was removed.

See https://github.com/metal3-io/cluster-api-provider-baremetal/blob/master/docs/api.md for more documentation on the baremetal machine providerspec.

@russellb
Copy link
Member

It looks like the name of the user-data secret is already passed in as an argument: https://github.com/openshift-metal3/kni-installer/blob/master/pkg/asset/machines/master.go#L166

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants