From 4f9ceaa750fe3dfb88b3ec4a337cbe6a30611d6a Mon Sep 17 00:00:00 2001
From: Mat Kowalski <mko@redhat.com>
Date: Tue, 25 May 2021 09:20:18 +0200
Subject: [PATCH] NO-ISSUE Add VM_EXTRADISKS_LIST and VM_EXTRADISKS_SIZE

This PR adds the ability to configure VM_EXTRADISKS_LIST and
VM_EXTRADISKS_SIZE that are required by the Assisted Service
to deploy the Local Storage Operator.

Configuration of the extra disks is automatically picked by the script
so that `storageClassDevices` in the `LocalVolume` manifest is filled
correctly with all the additional drives and does not require a manual
modification.

Co-authored-by: Lisa Rashidi-Ranjbar <lranjbar@redhat.com>
---
 assisted_deployment.sh | 19 ++++++++++++++++---
 config_example.sh      | 10 ++++++++++
 vm_setup_vars.yml      |  2 ++
 3 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/assisted_deployment.sh b/assisted_deployment.sh
index dafab1269..595e155c7 100755
--- a/assisted_deployment.sh
+++ b/assisted_deployment.sh
@@ -60,15 +60,28 @@ spec:
   logLevel: Normal
   managementState: Managed
   storageClassDevices:
-    - devicePaths:
-        - /dev/sdb
-        - /dev/sdc
+$(storage_devices_config)
       storageClassName: assisted-service
       volumeMode: Filesystem
 EOCR
 }
 
 
+function storage_devices_config() {
+  if [ ! -z "${VM_EXTRADISKS_LIST}" ]; then
+cat <<EOF
+    - devicePaths:
+EOF
+  fi
+
+  for disk in ${VM_EXTRADISKS_LIST}; do
+cat <<EOF
+        - /dev/$disk
+EOF
+  done
+}
+
+
 function deploy_hive() {
   echo "Installing Hive..."
 
diff --git a/config_example.sh b/config_example.sh
index ee9c164c9..1bcad06ed 100755
--- a/config_example.sh
+++ b/config_example.sh
@@ -197,6 +197,16 @@ set -x
 #export WORKER_DISK=20
 #export WORKER_VCPU=4
 
+# Add extradisks to VMs
+# export VM_EXTRADISKS=true
+
+# Configure how many extra disks to add to VMs. Takes a string of disk
+# names delimited by spaces. Example "vdb vdc"
+# export VM_EXTRADISKS_LIST="vdb vdc"
+
+# Configure size of extra disks added to VMs
+# export VM_EXTRADISKS_SIZE="10G"
+
 # Provide additional master/worker ignition configuration, will be
 # merged with the installer provided config, can be used to modify
 # the default nic configuration etc
diff --git a/vm_setup_vars.yml b/vm_setup_vars.yml
index c403829c5..004d75104 100644
--- a/vm_setup_vars.yml
+++ b/vm_setup_vars.yml
@@ -9,6 +9,8 @@ ironic_prefix: "{{ ironic_prefix }}"
 # in metal3-dev-env
 num_masters: 3
 num_workers: 1
+extradisks_list: "{{ lookup('env', 'VM_EXTRADISKS_LIST').split(' ') | default(['vdb']) }}"
+extradisks_size: "{{ lookup('env', 'VM_EXTRADISKS_SIZE') | default(['8G']) }}"
 flavors:
   master:
     memory: "{{ lookup('env', 'MASTER_MEMORY') | default('16384', true) }}"