Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Spec is unclear about what errors should look like. #403

Closed
n3wscott opened this issue Jan 4, 2018 · 4 comments
Closed

The Spec is unclear about what errors should look like. #403

n3wscott opened this issue Jan 4, 2018 · 4 comments
Assignees

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Jan 4, 2018

I think if the spec intends Error to be optionally returned for any error case it needs to be reworked. This is the language:

Service Brokers can include a user-facing message in the description field;

There is no spec language in that sentence, like MAY, and it is unclear is the broker author is allowed to return the description field for any responses or just for responses that call out they return errors.

The confusion happens when the spec says The expected response body is {}. This is redundant and unclear.

We should simplify errors to say they MAY always send error and description for all errors and remove the special cases for special errors.

@mattmcneeney
Copy link
Contributor

I agree @n3wscott - anytime an API error occurs, brokers should be able to return the same error object. This is much more straightforward for platforms to understand.

I know we have the openapi changes for this in #389. We should make a sweeping change to spec.md too to clarify this if everyone agrees this is sensible.

@fmui
Copy link
Member

fmui commented Jan 5, 2018

This is related to #375.

@mattmcneeney
Copy link
Contributor

Good spot @fmui. Although #375 looks like an extension to the spec (adding error codes) whereas this issue is regarding removing ambiguity.

@mattmcneeney
Copy link
Contributor

This is going to be resolved by #409 so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants