Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the branching strategy in the code around SQL_PAGINATION_API_SEARCH_AFTER check #2945

Open
manasvinibs opened this issue Aug 22, 2024 · 1 comment

Comments

@manasvinibs
Copy link
Member

We have introduced SQL_PAGINATION_API_SEARCH_AFTER config settings to choose the approach used for pagination queries. The default value is true today which uses Point in time with search_after API to paginate the results instead of existing scroll search API. Today we have branching strategy all across the code to support both the approaches. We need to get rid of this branching checks and improve the code or get rid of scroll approach once performance testing is done.

@manasvinibs
Copy link
Member Author

manasvinibs commented Sep 23, 2024

Minor imrpovements suggested:

  1. Add a separate PIT request implementation class in the OpenSearchQUeryRequest.java - https://github.com/opensearch-project/sql/pull/2981/files/770ae4151d3e46a9fcd8246690aa20b266f69d57#diff-96f998c99595de19404d0dd5c38b71b5fb7c52160cf34a847c2785dbb05f1d03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant