Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add limitations settings for datasource, query, sessions in domain level instead of datasource #2379

Closed
4 tasks done
penghuo opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request v2.11.1 Issues targeting release v2.11.1

Comments

@penghuo
Copy link
Collaborator

penghuo commented Oct 26, 2023

  • Max number of datasources per domain — 20

    • plugins.query.executionengine.spark.datasources.limit
  • Max number of refresh job of (skipping/covering/materialized views) per domain — 50

    • plugins.query.executionengine.spark.refresh_job.limit
  • Max number of concurrent sessions (for REPL jobs) per datasource - 100 (Existing feature)

    • plugins.query.executionengine.spark.session.limit
  • Max number of batch queries (in case if REPL is disabled)

    • we disable batch query, no need to add batch query limitation.
@penghuo penghuo added enhancement New feature or request untriaged v2.11.1 Issues targeting release v2.11.1 and removed untriaged labels Oct 26, 2023
@penghuo penghuo self-assigned this Oct 26, 2023
@penghuo
Copy link
Collaborator Author

penghuo commented Oct 27, 2023

Stage - I

Implement LeaseManagerService in Plugin.

  • QueryHandler borrow lease before execute the query.
  • LeaseManagerService check request against domain level concurrent limit.
  • LeaseManagerService running on data node and check limit based on cluster settings.

API

  • void LeaseManagerService.borrow(BorrowLeaseRequest request)
    • ConcurrencyLimitExceededException

Model

  • BorrowLeaseRequest
    • QueryType
    • DataSourceName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.11.1 Issues targeting release v2.11.1
Projects
None yet
Development

No branches or pull requests

1 participant