Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Paginate system queries in v2 #1712

Open
Yury-Fridlyand opened this issue Jun 6, 2023 · 1 comment
Open

[FEATURE] Paginate system queries in v2 #1712

Yury-Fridlyand opened this issue Jun 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request pagination Pagination feature, ref #656

Comments

@Yury-Fridlyand
Copy link
Collaborator

Is your feature request related to a problem?
Pagination mechanism in V2 should support system queries like SHOW TABLES or DESCRIBE TABLES.

What solution would you like?
Two options here

  1. Ignore fetch_size parameter for such queries and always return non-paginated response. V1 works so.
  2. Cache entire result set in the cursor and return it paginated.

What alternatives have you considered?
N/A

Do you have any additional context?
N/A

@Yury-Fridlyand Yury-Fridlyand added enhancement New feature or request untriaged pagination Pagination feature, ref #656 and removed untriaged labels Jun 6, 2023
@Yury-Fridlyand Yury-Fridlyand self-assigned this Jun 6, 2023
@dai-chen
Copy link
Collaborator

dai-chen commented Jun 7, 2023

I think option 1 makes sense and we can follow V1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pagination Pagination feature, ref #656
Projects
None yet
Development

No branches or pull requests

2 participants