Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support other model types in CreateAlertTool and CreateAnomalyDetectorTool #447

Open
yuye-aws opened this issue Oct 20, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request untriaged

Comments

@yuye-aws
Copy link
Member

Is your feature request related to a problem?
CreateAlertTool and CreateAnomalyDetectorTool only supports Claude and OpenAI as the model types. We need to support more model types. Just like: https://opensearch.org/docs/latest/ml-commons-plugin/remote-models/connectors/.

What solution would you like?
Refer to the connector and model interface in ml commons. Model interface document: https://opensearch.org/docs/latest/ml-commons-plugin/api/model-apis/register-model/.

What alternatives have you considered?
I'll look into the current implementation of connector and model interface. We'll reach a conclusion after discussing with tool owner @gaobinlong and @qianheng-aws.

Do you have any additional context?
These 2 tools needs model_type parameter due to prompt customization.

@yuye-aws yuye-aws added enhancement New feature or request untriaged labels Oct 20, 2024
@yuye-aws
Copy link
Member Author

Please assign this issue to me thanks!

@zane-neo
Copy link
Collaborator

I suggest we can make this a flexible implementation which can adapt to more and more models automatically w/o blocking user's integration.

@yuye-aws
Copy link
Member Author

I suggest we can make this a flexible implementation which can adapt to more and more models automatically w/o blocking user's integration.

Agreed. The CreateAnomalyDetectorTool now supports every model_type with the prompt parameter. The CreateAlertTool can follow the existing implementation of CreateAnomalyDetectorTool.

@yuye-aws
Copy link
Member Author

@heng has created a PR: #452

@yuye-aws
Copy link
Member Author

yuye-aws commented Oct 29, 2024

Hi @gaobinlong ! Do you think the comment also makes sense for CreateAnomalyDetectorTool? If so, can you create a small PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants