-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that dual mode enabled flag from cluster settings can get propagated to core #4820
Merged
willyborankin
merged 5 commits into
opensearch-project:main
from
cwperks:dynamic-dual-mode
Oct 21, 2024
Merged
Ensure that dual mode enabled flag from cluster settings can get propagated to core #4820
willyborankin
merged 5 commits into
opensearch-project:main
from
cwperks:dynamic-dual-mode
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agated to core Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
October 18, 2024 18:28
3 tasks
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
==========================================
- Coverage 70.99% 70.77% -0.22%
==========================================
Files 310 310
Lines 20938 20942 +4
Branches 3326 3326
==========================================
- Hits 14865 14822 -43
- Misses 4325 4374 +49
+ Partials 1748 1746 -2
|
Signed-off-by: Craig Perkins <[email protected]>
nibix
reviewed
Oct 19, 2024
src/integrationTest/java/org/opensearch/security/EncryptionInTransitMigrationTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
nibix
approved these changes
Oct 19, 2024
kumargu
approved these changes
Oct 21, 2024
willyborankin
approved these changes
Oct 21, 2024
willyborankin
merged commit Oct 21, 2024
811f26d
into
opensearch-project:main
41 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…agated to core (#4820) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 811f26d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion core PR: opensearch-project/OpenSearch#16387
Overrides a new method in the SecureTransportSettingsProvider interface to allow the security plugin to feed this value to core. This is required since the security plugin has a listener on cluster settings and allows this setting to be changed dynamically irrespective of the value in opensearch.yml
Bug fix
Testing
latest-dual-mode.zip
^ Attached above is a sample docker configuration for a 3 node cluster. node1 is commented out originally. All paths in the volumes are paths on my local machine and would need to change for a reproduction.
./gradlew localDistro
to create local snapshot jars for your distro./gradlew assemble
to create snapshot jars that get placed inbuild/distributions/
directorydocker compose down -v && docker compose up
docker compose up opensearch-node1
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.