Update Log4JSink Default from sgaudit to audit and add test for default values #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt values Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
willyborankin
approved these changes
Mar 20, 2024
peternied
requested changes
Mar 20, 2024
peternied
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4146 +/- ##
=======================================
Coverage 66.00% 66.00%
=======================================
Files 299 299
Lines 21385 21385
Branches 3478 3478
=======================================
Hits 14115 14115
+ Misses 5529 5527 -2
- Partials 1741 1743 +2
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
…lt values (#4146) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 6f79d09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
stephen-crawford
pushed a commit
that referenced
this pull request
Mar 22, 2024
… test for default values (#4155) Backport 6f79d09 from #4146. --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…lt values (opensearch-project#4146) Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the default logger name in the Log4JSink from
sgaudittoaudit. This PR also adds a test case that asserts the default value for the logger name.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.