Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Refactor asn1TaggedObject.getObject() call #4728

Closed
terryquigleysas opened this issue Sep 12, 2024 · 2 comments · Fixed by #4729
Closed

[ENHANCEMENT] Refactor asn1TaggedObject.getObject() call #4728

terryquigleysas opened this issue Sep 12, 2024 · 2 comments · Fixed by #4729
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@terryquigleysas
Copy link
Contributor

terryquigleysas commented Sep 12, 2024

Is your feature request related to a problem?
With the view of working towards supporting multiple security providers (FIPS and non-FIPS) the call to asn1TaggedObject.getObject() in DefaultSecurityKeyStore can be refactored to support the methods available in either library.

What solution would you like?
Use reflection to refactor asn1TaggedObject.getObject() in DefaultSecurityKeyStore depending on the provider in the classpath.

See code from original Proof of Concept
2.11...terryquigleysas:security:2.11#diff-a491b91660e8230b6a8806f07ba0ec35c8d22a92f69411a81d156be58fffa9bdL1180

What alternatives have you considered?
The security plugin cannot be changed to use the FIPS Bouncy Castle libraries alone as it would break OpenSAML use and extensive associated work is required for these to work with OpenSearch core and potentially certain other plugins.

Do you have any additional context?
See related issues:
#3420
#1497
#1500
#3317
#4583
#4587

@terryquigleysas terryquigleysas added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Sep 12, 2024
@terryquigleysas
Copy link
Contributor Author

Please assign to me if happy with it. I will provide a PR.

@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Sep 16, 2024
@cwperks
Copy link
Member

cwperks commented Sep 16, 2024

[Triage] Thank you for filing this issue @terryquigleysas. I assigned the issue to you. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants