Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] install_demo_configuration.[sh|bat] assumeyes behavior not working as expected #2402

Open
cwperks opened this issue Jan 13, 2023 · 6 comments
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Jan 13, 2023

What is the bug?

The install_demo_configuration scripts are not actually setting all prompts to y when using the -y option as you would expect. This issue was initially uncovered in this PR: #2308

In addition to the behavior of -y, there is no command line option available to only install the demo certificates and leave initsecurity and cluster_mode as false.

The install_demo_configuration scripts should be updated with a -y option that actually accepts all prompts and a new option should be added to only install the demo certificates.

@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 13, 2023
@stephen-crawford
Copy link
Contributor

stephen-crawford commented Jan 13, 2023

It looks like opensearch build makes use of the -y command in opensearch-docker-entrypoint.sh, opensearch-tar-install, opensearch-onetime-setup.sh, and the two build templates for rpm and debian post-installation.

@peternied
Copy link
Member

Bugs like this are a good reason to migrate away from our current command line scripts.

@stephen-crawford
Copy link
Contributor

stephen-crawford commented Jan 17, 2023

[Triage] @scrawfor99 add documentation change to address that the code will not be corrected / follow up with the build team about desired change for the behavior.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 17, 2023
@stephen-crawford stephen-crawford self-assigned this Jan 17, 2023
@davidlago
Copy link

@cwperks updates on this issue?

@cwperks
Copy link
Member Author

cwperks commented Jan 4, 2024

@cwperks cwperks closed this as completed Jan 4, 2024
@cwperks cwperks reopened this Jan 10, 2024
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jan 10, 2024
@DarshitChanpura
Copy link
Member

This bug fix touches a number of different repositories as they already use -i with -y option.

Proposed Fix:

  • Introduce a new option to generate demo certs : -d
  • Modify the tool to assume -d, -i, -c as yes when -y is passed. Else individual options need to be passed
  • Modify different distributions and integ tests across different repositories.

@peternied peternied removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

5 participants