Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Sanity test to 1.x branch #2398

Open
DarshitChanpura opened this issue Jan 11, 2023 · 5 comments
Open

Backport Sanity test to 1.x branch #2398

DarshitChanpura opened this issue Jan 11, 2023 · 5 comments
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@DarshitChanpura
Copy link
Member

Backport sanity tests introduced in #1958.

This change isn't a simple backport as it involves modifying build.gradle as significant changes were made to it moving from 1.x to 2.x.

@DarshitChanpura DarshitChanpura added untriaged Require the attention of the repository maintainers and may need to be prioritized and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 11, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jan 11, 2023
@peternied peternied changed the title [1.x] Backport Sanity test to 1.x branch Backport Sanity test to 1.x branch Jan 12, 2023
@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. sprint backlog and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 17, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Thank you @DarshitChanpura, this seems like a good issue that will be addressed to allow for backporting to 1.3 as well.

@stephen-crawford
Copy link
Contributor

@DarshitChanpura, I can help pick this up.

@stephen-crawford stephen-crawford self-assigned this Jan 24, 2023
@peternied
Copy link
Member

I don't think we can 'backport' these tests. I think we need to reauthor these tests in a way that will work in the 1.X ecosystem.

Have we considered replacing OpenSearchRestTestCase and creating a task triggered by scripts/integtest.sh that can send those parameters into the test cases?

@DarshitChanpura
Copy link
Member Author

Have we considered replacing OpenSearchRestTestCase and creating a task triggered by scripts/integtest.sh that can send those parameters into the test cases?

That is how these tests are configured currently [1][2]

[1] https://github.com/DarshitChanpura/security/blob/main/src/test/java/org/opensearch/security/sanity/tests/SecurityRestTestCase.java
[2] https://github.com/DarshitChanpura/security/blob/main/README.md#test-and-build

@peternied
Copy link
Member

@DarshitChanpura The linked example uses OpenSearchRestTestCase, I mean completely replacing the base class with an alternative that is viable in the 1.x branch. Maybe we have to write it from scratch or modify the existing base test class used by the security plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

4 participants