Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI runs with outdated maven jars for core that lead to failing checks #2276

Closed
cwperks opened this issue Nov 23, 2022 · 4 comments
Closed
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Nov 23, 2022

What is the bug?

During a recent dependency upgrade (#2269), the WhiteSource security check failed because it identified outdated dependencies in zip output of ./gradlew assemble for the security plugin. The problem with the check is that it relies on outdated 1.4.0-SNAPSHOT dependency of core which was bringing in the outdated dependency and the dependency has since been upgraded in the corresponding branch of core.

When running everything locally and publishing core's SNAPSHOT build to maven (m2) local, the dependencies are upgraded and would not get flagged.

Stale snapshots have been an issue with previous builds and require a successful distribution build to get new snapshots published to the remote maven repository (maven central or something else?).

At build time we could add a step in the github workflow to checkout the same branch of core and perform ./gradlew publishToMavenLocal to avoid the issue with stale SNAPSHOTs.

PR on 1.3 with up-to-date artifacts for core that passes WhiteSource security check:

Screen Shot 2022-11-23 at 3 34 48 PM

PR on 1.x with up-to-date stale artifacts for core that fails WhiteSource security check:

Screen Shot 2022-11-23 at 3 34 27 PM

WhiteSource report flagging outdated netty:

Screen Shot 2022-11-23 at 3 47 09 PM

When run locally this is what is contained in the security plugin zip. The resolved version of netty is 4.1.84.Final:

Screen Shot 2022-11-23 at 3 37 22 PM

@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 23, 2022
@stephen-crawford
Copy link
Contributor

Excellent. This was a really good idea you had and helps make the suggestions you and @DarshitChanpura had actionable. What do we want to do moving forward for making sure we do not run into stuff like this?

Should we reach out to the build repository or do we want to write an action that can be called to create updated artifacts?

@RyanL1997 RyanL1997 added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 28, 2022
@RyanL1997
Copy link
Collaborator

[Triaged] @cwperks Could you please follow up on this one?

@davidlago
Copy link

@cwperks is this issue still relevant?

@cwperks
Copy link
Member Author

cwperks commented Jan 4, 2024

The gradle cache was disabled so this issue can be closed.

@cwperks cwperks closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

4 participants