-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the "Master" nomenclature #1664
Comments
For 2.0, at a minimum please ensure that the plugin is not calling any deprecated APIs in core or another plugin, and confirm below, then remove the 2.0.0 label. If you have time, do the complete deprecation as described in this issue. |
|
Before we close this lets add a checkstyle rule to look for this terminology and error if it is detected |
No more action items for this issue. |
Searching for 'master' in our codebase has 26 results. Lets see if we can get that to zero, that checkstyle rule hasn't been enabled, we should turn it on and also drive that count to zero. |
There are multiple APIs in OpenSearch core still have |
Hey @cliu123, thanks for pointing out. I'm trying deprecating all the Java APIs (public class, method, variable) with "master" terminology, and providing the alternative usage with "cluster manager" in OpenSearch 2.1 by the issue opensearch-project/OpenSearch#1684. |
Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472, with the plan for its terminology replacement.
Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.
Describe the solution you'd like
Replace the terminology "master" with "cluster manager".
When being compatible with OpenSearch 2.0:
replace
cluster.initial_master_nodes
withcluster.initial_cluster_manager_nodes
in https://github.com/opensearch-project/security/blob/1.3.1.0/tools/install_demo_configuration.sh#L385When being compatible with OpenSearch 3.0:
Describe alternatives you've considered
None.
Additional context
An existing PR: #1746
The text was updated successfully, but these errors were encountered: