-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backwards compatibility tests for automation #1417
Comments
@opensearch-project/opensearch-core Security plugin BWC tests require to run some scripts to install some demo certificates before start clusters. This needs some help from OpenSearch core team. Anyone can help with this? Cc: @CEHENKLE @saratvemulapalli @VachaShah |
@cliu123 does it have to be manual scripts? What exactly are you trying to install? |
@saratvemulapalli Thanks for jumping on this! Security plugin needs to run this script to generate demo certificates and to update the configurations in |
I know @VachaShah is taking a deeper look. But see if this works for you: You can generate them on the fly, put it in your test resources and feed it to the test clusters. |
Thank you @saratvemulapalli for pointing this out! @cliu123 Can you try this? All the settings that can be added to a test cluster node are: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fgradle%2Ftestclusters%2FOpenSearchNode.java |
@saratvemulapalli @VachaShah Thanks for the suggestion! Let me try that. |
The changes that @saratvemulapalli pointed to seem have resolved the certificates and configuration issue. And not nodes are not connecting to each other.
|
@cliu123 It looks to be some issue with the SSL record:
The first node has this issue, so once security is setup, the other nodes are not able to join since the first node is the primary node. |
@VachaShah But isn't this supposed to install security plugin on each of the nodes? Why security plugin is only installed on the first node, but not installed on other nodes?
Looks like the nodes were initialized, but they couldn't join the cluster for some reason.
|
Security plugin looks to be getting installed on all nodes when the nodes are created, from the logs:
|
@VachaShah Thanks! Yes, security plugin can be installed on all nodes, but cluster formation fails. Discussed with @dbbaughe on the cluster formation issue, and confirmed that ISM security-enabled tests never worked on internal cuslter formed by ES/OS test framework. The internal groovy code that was constructing the internal cluster in ES core had hardcoded branching logic that was specific to their security implementation, so OpenSearch test framework(forked from ES test framework) cannot form a cluster with security enabled. This needs to fix the buildSrc in core where the internal cluster is being formed. buildSrc has logic in it that was specific to Elastics implementation of security which wasn't something that we could easily hook into and set the values we needed to set up the security plugin. With the current issue, running security-enabled tests with @opensearch-project/engineering-effectiveness Would you please point me to where the process to create an external test cluster with security enabled and to point tests to the cluster?
|
Hi @cliu123 You can check our code base for running integration on external (localhost:9200) local clusters here https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/integ_test/integ_test_suite_opensearch.py. |
@gaiksaya Thank you! @opensearch-project/opensearch-core Would you please help look into this cluster formation issue? More logs:
|
ODFE/ES cluster formation is not successfuly. |
@cliu123 could you provide the steps to see this problem? It might make sense to make a separate issue to track this. |
There is no manual steps. The BWC tests don't run against ODFE/ES versions. |
Add backwards compatibility tests for the plugin to automate end-to-end upgrade paths for faster releases. Developer documentation for implementing bwc tests and hooking them to CI: https://github.com/opensearch-project/opensearch-plugins/blob/main/TESTING.md#backwards-compatibility-testing
The text was updated successfully, but these errors were encountered: