Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add new ml-commons transport actions #1181

Closed
ylwu-amzn opened this issue Nov 2, 2022 · 2 comments · Fixed by #1182
Closed

[FEATURE] Add new ml-commons transport actions #1181

ylwu-amzn opened this issue Nov 2, 2022 · 2 comments · Fixed by #1182
Labels
enhancement New feature or request untriaged

Comments

@ylwu-amzn
Copy link
Contributor

Is your feature request related to a problem?
We build several new transport actions in ml-commons for 2.4 release. So we need to add them to constants list.

What solution would you like?
Add to constants file.

What alternatives have you considered?
like this PR #912

Do you have any additional context?
N/A

@ylwu-amzn ylwu-amzn added enhancement New feature or request untriaged labels Nov 2, 2022
@peternied
Copy link
Member

@ylwu-amzn It seems like this issue is for a pending pull request - we are happy to accept pull requests without issues associated with them so long as they capture the 'why' in their description.

@ylwu-amzn
Copy link
Contributor Author

ylwu-amzn commented Nov 2, 2022

Oh, got it, I will publish a PR soon and explain why in PR description.
Feel free to close it if you think it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants