diff --git a/public/apps/configuration/app-router.tsx b/public/apps/configuration/app-router.tsx index eb987e7a..a5f63b99 100644 --- a/public/apps/configuration/app-router.tsx +++ b/public/apps/configuration/app-router.tsx @@ -108,9 +108,10 @@ export const allNavPanelUrls = (multitenancyEnabled: boolean) => ...(multitenancyEnabled ? [buildUrl(ResourceType.tenantsConfigureTab)] : []), ]); -function decodeParams(params: { [k: string]: string }): any { - return Object.keys(params).reduce((obj: { [k: string]: string }, key: string) => { - obj[key] = decodeURIComponent(params[key]); +function decodeParams(params: { [k: string]: string | undefined }): any { + return Object.keys(params).reduce((obj: { [k: string]: string | undefined }, key: string) => { + const value = params[key]; + obj[key] = value !== undefined ? decodeURIComponent(value) : undefined; return obj; }, {}); } diff --git a/public/apps/configuration/panels/audit-logging/audit-logging.tsx b/public/apps/configuration/panels/audit-logging/audit-logging.tsx index 1b05e42d..943a4afe 100644 --- a/public/apps/configuration/panels/audit-logging/audit-logging.tsx +++ b/public/apps/configuration/panels/audit-logging/audit-logging.tsx @@ -263,15 +263,17 @@ export function AuditLogging(props: AuditLoggingProps) { coreStart={props.coreStart} navigation={props.depsStart.navigation} fallBackComponent={ - - -

Audit logging

-
-
+ <> + + +

Audit logging

+
+
+ + } resourceType={ResourceType.auditLogging} /> - {loading ? : content} ); diff --git a/public/apps/configuration/panels/audit-logging/test/__snapshots__/audit-logging.test.tsx.snap b/public/apps/configuration/panels/audit-logging/test/__snapshots__/audit-logging.test.tsx.snap index e22e5956..6ce5f42c 100644 --- a/public/apps/configuration/panels/audit-logging/test/__snapshots__/audit-logging.test.tsx.snap +++ b/public/apps/configuration/panels/audit-logging/test/__snapshots__/audit-logging.test.tsx.snap @@ -273,20 +273,22 @@ exports[`Audit logs render when AuditLoggingSettings.enabled is true 1`] = ` } } fallBackComponent={ - - -

- Audit logging -

-
-
+ + + +

+ Audit logging +

+
+
+ +
} navigation={Object {}} resourceType="auditLogging" /> - - -

- Audit logging -

-
- + + + +

+ Audit logging +

+
+
+ +
} navigation={Object {}} resourceType="auditLogging" /> - diff --git a/public/apps/configuration/panels/role-edit/role-edit.tsx b/public/apps/configuration/panels/role-edit/role-edit.tsx index ef4a104f..0ec79109 100644 --- a/public/apps/configuration/panels/role-edit/role-edit.tsx +++ b/public/apps/configuration/panels/role-edit/role-edit.tsx @@ -281,6 +281,7 @@ export function RoleEdit(props: RoleEditDeps) { descriptionControls={descriptionData} resourceType={ResourceType.roles} subAction={TITLE_TEXT_DICT[props.action]} + pageTitle={props.sourceRoleName} />