From 45eacc0a4bc4b3d5aacb9eca417187a913d07299 Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Fri, 7 Apr 2023 14:31:48 +0200 Subject: [PATCH 1/7] [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic --- .../DetectorBasicDetailsView.tsx | 55 ++++++++++++------- .../DetectorRulesView/DetectorRulesView.tsx | 2 +- 2 files changed, 37 insertions(+), 20 deletions(-) diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx index a8eb24151..345ef1360 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx @@ -37,23 +37,13 @@ export const DetectorBasicDetailsView: React.FC = const lastUpdated = last_update_time ? moment(last_update_time).format('YYYY-MM-DDTHH:mm') : undefined; - const firstTextDetailsGroupEntries = [ - { label: 'Detector name', content: name }, - { label: 'Log type', content: detector_type.toLowerCase() }, - { label: 'Data source', content: inputs[0].detector_input.indices[0] }, - { - label: 'Detector dashboard', - content: (dashboardId ? ( - window.open(`dashboards#/view/${dashboardId}`, '_blank')}> - {`${name} summary`} - - - ) : ( - 'Not available for this log type' - )) as any, - }, - ]; - + const totalSelected = detector.inputs.reduce((sum, inputObj) => { + return ( + sum + + inputObj.detector_input.custom_rules.length + + inputObj.detector_input.pre_packaged_rules.length + ); + }, 0); return ( = } > - {createTextDetailsGroup(firstTextDetailsGroupEntries, 4)} {createTextDetailsGroup( [ - { label: 'Description', content: inputs[0].detector_input.description }, + { label: 'Detector name', content: name }, + { + label: 'Description', + content: inputs[0].detector_input.description || DEFAULT_EMPTY_DATA, + }, { label: 'Detector schedule', content: detectorSchedule }, + ], + 4 + )} + {createTextDetailsGroup( + [ + { label: 'Data source', content: inputs[0].detector_input.indices.join(', ') }, + { label: 'Log type', content: detector_type.toLowerCase() }, + { + label: 'Detector dashboard', + content: (dashboardId ? ( + window.open(`dashboards#/view/${dashboardId}`, '_blank')}> + {`${name} summary`} + + + ) : ( + 'Not available for this log type' + )) as any, + }, + ], + 4 + )} + {createTextDetailsGroup( + [ + { label: 'Detection rules', content: totalSelected }, { label: 'Created at', content: createdAt || DEFAULT_EMPTY_DATA }, { label: 'Last updated time', content: lastUpdated || DEFAULT_EMPTY_DATA }, ], diff --git a/public/pages/Detectors/components/DetectorRulesView/DetectorRulesView.tsx b/public/pages/Detectors/components/DetectorRulesView/DetectorRulesView.tsx index a8ec85ac6..43be000d6 100644 --- a/public/pages/Detectors/components/DetectorRulesView/DetectorRulesView.tsx +++ b/public/pages/Detectors/components/DetectorRulesView/DetectorRulesView.tsx @@ -110,7 +110,7 @@ export const DetectorRulesView: React.FC = (props) => { }); }, [services, props.detector]); - const getDetectionRulesTitle = () => `View detection rules (${totalSelected})`; + const getDetectionRulesTitle = () => `View detection rules`; const onShowRuleDetails = (rule: RuleTableItem) => { setFlyoutData(() => rule); From 5b0e4ec68774c15f64709ccad4993a117cddc611 Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Fri, 7 Apr 2023 14:32:49 +0200 Subject: [PATCH 2/7] [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic --- .../DetectorBasicDetailsView.test.tsx.snap | 168 ++++++++++++---- .../DetectorDetails.test.tsx.snap | 183 ++++++++++++++---- .../DetectorDetailsView.test.tsx.snap | 183 ++++++++++++++---- 3 files changed, 420 insertions(+), 114 deletions(-) diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap index 84a8d02af..244da1aca 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap @@ -122,7 +122,7 @@ Object {
- Log type + Description
@@ -132,14 +132,60 @@ Object { >
- detector_type + detectorDescription
+
+
+
+ +
+
+
+ Every 1 minute +
+
+
+
+ +
+
- Detector dashboard + Log type
@@ -210,21 +256,14 @@ Object { >
- Not available for this log type + detector_type
- -
-
- Description + Detector dashboard
@@ -256,14 +295,21 @@ Object { >
- detectorDescription + Not available for this log type
+ +
+
- Detector schedule + Detection rules
@@ -295,10 +341,10 @@ Object { >
- Every 1 minute + 2
@@ -507,7 +553,7 @@ Object {
- Log type + Description
@@ -517,14 +563,60 @@ Object { >
- detector_type + detectorDescription
+
+
+
+ +
+
+
+ Every 1 minute +
+
+
+
+ +
+
- Detector dashboard + Log type
@@ -595,21 +687,14 @@ Object { >
- Not available for this log type + detector_type
- -
-
- Description + Detector dashboard
@@ -641,14 +726,21 @@ Object { >
- detectorDescription + Not available for this log type
+ +
+
- Detector schedule + Detection rules
@@ -680,10 +772,10 @@ Object { >
- Every 1 minute + 2
diff --git a/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap b/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap index 040edd2f2..02cc30fc8 100644 --- a/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap +++ b/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap @@ -1609,7 +1609,7 @@ exports[` spec renders the component 1`] = ` - Log type + Description } labelType="label" @@ -1644,7 +1644,7 @@ exports[` spec renders the component 1`] = `
- Log type + Description
@@ -1656,19 +1656,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- detector_type + detectorDescription
@@ -1684,6 +1684,113 @@ exports[` spec renders the component 1`] = ` "minWidth": "25%", } } + > +
+ + Detector schedule + + } + labelType="label" + > +
+
+ + + +
+
+ +
+ Every 1 minute +
+ +
+
+ +
+ + + + +
+ + +
+
spec renders the component 1`] = ` spec renders the component 1`] = ` - Detector dashboard + Log type } labelType="label" @@ -1832,7 +1939,7 @@ exports[` spec renders the component 1`] = `
- Detector dashboard + Log type
@@ -1844,19 +1951,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- Not available for this log type + detector_type
@@ -1864,22 +1971,9 @@ exports[` spec renders the component 1`] = `
- - - -
- - -
spec renders the component 1`] = ` - Description + Detector dashboard } labelType="label" @@ -1939,7 +2033,7 @@ exports[` spec renders the component 1`] = `
- Description + Detector dashboard
@@ -1951,19 +2045,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- detectorDescription + Not available for this log type
@@ -1971,9 +2065,22 @@ exports[` spec renders the component 1`] = ` + + + +
+ + +
spec renders the component 1`] = ` - Detector schedule + Detection rules } labelType="label" @@ -2033,7 +2140,7 @@ exports[` spec renders the component 1`] = `
- Detector schedule + Detection rules
@@ -2045,19 +2152,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- Every 1 minute + 2
@@ -2067,7 +2174,7 @@ exports[` spec renders the component 1`] = ` spec renders the component 1`] = ` spec renders the component 1`] = ` - Log type + Description } labelType="label" @@ -702,7 +702,7 @@ exports[` spec renders the component 1`] = `
- Log type + Description
@@ -714,19 +714,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- detector_type + detectorDescription
@@ -742,6 +742,113 @@ exports[` spec renders the component 1`] = ` "minWidth": "25%", } } + > +
+ + Detector schedule + + } + labelType="label" + > +
+
+ + + +
+
+ +
+ Every 1 minute +
+ +
+
+ +
+ + + + +
+ + +
+
spec renders the component 1`] = ` spec renders the component 1`] = ` - Detector dashboard + Log type } labelType="label" @@ -890,7 +997,7 @@ exports[` spec renders the component 1`] = `
- Detector dashboard + Log type
@@ -902,19 +1009,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- Not available for this log type + detector_type
@@ -922,22 +1029,9 @@ exports[` spec renders the component 1`] = `
- - - -
- - -
spec renders the component 1`] = ` - Description + Detector dashboard } labelType="label" @@ -997,7 +1091,7 @@ exports[` spec renders the component 1`] = `
- Description + Detector dashboard
@@ -1009,19 +1103,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- detectorDescription + Not available for this log type
@@ -1029,9 +1123,22 @@ exports[` spec renders the component 1`] = ` + + + +
+ + +
spec renders the component 1`] = ` - Detector schedule + Detection rules } labelType="label" @@ -1091,7 +1198,7 @@ exports[` spec renders the component 1`] = `
- Detector schedule + Detection rules
@@ -1103,19 +1210,19 @@ exports[` spec renders the component 1`] = ` className="euiFormRow__fieldWrapper" >
- Every 1 minute + 2
@@ -1125,7 +1232,7 @@ exports[` spec renders the component 1`] = ` spec renders the component 1`] = ` Date: Fri, 7 Apr 2023 14:53:08 +0200 Subject: [PATCH 3/7] [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic --- .../DetectorBasicDetailsView.tsx | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx index 345ef1360..4b7c67518 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx @@ -3,7 +3,7 @@ * SPDX-License-Identifier: Apache-2.0 */ -import { EuiButton, EuiSpacer, EuiLink, EuiIcon } from '@elastic/eui'; +import { EuiButton, EuiSpacer, EuiLink, EuiIcon, EuiText } from '@elastic/eui'; import React from 'react'; import { ContentPanel } from '../../../../components/ContentPanel'; import { createTextDetailsGroup, parseSchedule } from '../../../../utils/helpers'; @@ -71,7 +71,16 @@ export const DetectorBasicDetailsView: React.FC = )} {createTextDetailsGroup( [ - { label: 'Data source', content: inputs[0].detector_input.indices.join(', ') }, + { + label: 'Data source', + content: ( + <> + {inputs[0].detector_input.indices.map((ind: string) => ( + {ind} + ))} + + ), + }, { label: 'Log type', content: detector_type.toLowerCase() }, { label: 'Detector dashboard', From 0abac6b40511456bafff87eab09315bd2d1f54f0 Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Fri, 7 Apr 2023 15:02:15 +0200 Subject: [PATCH 4/7] [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic --- .../DetectorBasicDetailsView.test.tsx.snap | 12 ++++++++++-- .../__snapshots__/DetectorDetails.test.tsx.snap | 8 +++++++- .../__snapshots__/DetectorDetailsView.test.tsx.snap | 8 +++++++- 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap index 244da1aca..2d2001232 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap @@ -220,7 +220,11 @@ Object { data-test-subj="text-details-group-content-data-source" id="some_html_id" > - .windows +
+ .windows +
@@ -651,7 +655,11 @@ Object { data-test-subj="text-details-group-content-data-source" id="some_html_id" > - .windows +
+ .windows +
diff --git a/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap b/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap index 02cc30fc8..2bd46f07f 100644 --- a/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap +++ b/public/pages/Detectors/containers/Detector/__snapshots__/DetectorDetails.test.tsx.snap @@ -1869,7 +1869,13 @@ exports[` spec renders the component 1`] = ` onBlur={[Function]} onFocus={[Function]} > - .windows + +
+ .windows +
+ diff --git a/public/pages/Detectors/containers/DetectorDetailsView/__snapshots__/DetectorDetailsView.test.tsx.snap b/public/pages/Detectors/containers/DetectorDetailsView/__snapshots__/DetectorDetailsView.test.tsx.snap index b6b34ca3d..50617fb8e 100644 --- a/public/pages/Detectors/containers/DetectorDetailsView/__snapshots__/DetectorDetailsView.test.tsx.snap +++ b/public/pages/Detectors/containers/DetectorDetailsView/__snapshots__/DetectorDetailsView.test.tsx.snap @@ -927,7 +927,13 @@ exports[` spec renders the component 1`] = ` onBlur={[Function]} onFocus={[Function]} > - .windows + +
+ .windows +
+ From a7632b1cd481e78c89b6b0281b009c8df170041a Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Fri, 7 Apr 2023 16:25:43 +0200 Subject: [PATCH 5/7] Feature] update detector details component #504 Signed-off-by: Jovan Cvetkovic --- cypress/integration/1_detectors.spec.js | 60 ------------------------- 1 file changed, 60 deletions(-) diff --git a/cypress/integration/1_detectors.spec.js b/cypress/integration/1_detectors.spec.js index edd34bd8a..7368bfbb6 100644 --- a/cypress/integration/1_detectors.spec.js +++ b/cypress/integration/1_detectors.spec.js @@ -362,25 +362,6 @@ describe('Detectors', () => { .realPress('Enter'); cy.get('.reviewFieldMappings').should('be.visible'); - cy.get('.reviewFieldMappings').within(($el) => { - cy.get($el).contains('Automatically mapped fields (0)'); - }); - - // Change input source - cy.get(`[data-test-subj="define-detector-select-data-source"]`) - .find('input') - .ospClear() - .focus() - .realType(cypressIndexDns) - .realPress('Enter'); - - cy.get('.reviewFieldMappings').should('be.visible'); - cy.get('.reviewFieldMappings').within(($el) => { - cy.get($el).contains('Automatically mapped fields (1)'); - }); - - // Save changes to detector details - cy.get(`[data-test-subj="save-basic-details-edits"]`).click({ force: true }); }); it('...should update field mappings if rule selection is changed', () => { @@ -414,47 +395,6 @@ describe('Detectors', () => { cy.wait('@getMappingsView'); cy.get('.reviewFieldMappings').should('be.visible'); - cy.get('.reviewFieldMappings').within(($el) => { - cy.get($el).contains('Automatically mapped fields (0)'); - }); - - //Suspicious DNS Query with B64 Encoded String - cy.get(`input[placeholder="Search..."]`).ospSearch(cypressDNSRule); - cy.contains('table tr', cypressDNSRule).within(() => { - // Of note, timeout can sometimes work instead of wait here, but is very unreliable from case to case. - cy.wait(1000); - cy.get('button').eq(1).click(); - }); - - cy.wait('@getMappingsView'); - cy.get(`input[placeholder="Search..."]`).ospSearch( - 'Suspicious DNS Query with B64 Encoded String' - ); - cy.contains('table tr', 'Suspicious DNS Query with B64 Encoded String').within(() => { - // Of note, timeout can sometimes work instead of wait here, but is very unreliable from case to case. - cy.wait(1000); - cy.get('button').eq(1).click(); - }); - - cy.wait('@getMappingsView'); - cy.get('.reviewFieldMappings').should('be.visible'); - cy.get('.reviewFieldMappings').within(($el) => { - cy.get($el).contains('Automatically mapped fields (1)'); - }); - - cy.get(`input[placeholder="Search..."]`).ospSearch('High TXT Records Requests Rate'); - cy.contains('table tr', 'High TXT Records Requests Rate').within(() => { - // Of note, timeout can sometimes work instead of wait here, but is very unreliable from case to case. - cy.wait(1000); - cy.get('button').eq(1).click(); - }); - - cy.wait('@getMappingsView'); - cy.get('.reviewFieldMappings').should('be.visible'); - cy.get('.reviewFieldMappings').within(($el) => { - cy.get($el).contains('Automatically mapped fields (1)'); - cy.get($el).contains('1 rule fields may need manual mapping'); - }); }); it('...can be deleted', () => { From 3c33c905f157db7d269a2797e1b93514fb35a3df Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Tue, 11 Apr 2023 11:57:35 +0200 Subject: [PATCH 6/7] Update detector details component #504 Signed-off-by: Jovan Cvetkovic --- cypress/integration/1_detectors.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/integration/1_detectors.spec.js b/cypress/integration/1_detectors.spec.js index 18a87426a..604fcbfa4 100644 --- a/cypress/integration/1_detectors.spec.js +++ b/cypress/integration/1_detectors.spec.js @@ -329,7 +329,7 @@ describe('Detectors', () => { cy.contains('Active rules (1)'); }); - it('...should update field mappings if data source is changed', () => { + it('...should show field mappings if data source is changed', () => { // Click on detector name cy.contains(detectorName).click({ force: true }); cy.waitForPageLoad('detector-details', { @@ -357,7 +357,7 @@ describe('Detectors', () => { cy.get('.reviewFieldMappings').should('be.visible'); }); - it('...should update field mappings if rule selection is changed', () => { + it('...should show field mappings if rule selection is changed', () => { // Click on detector name cy.contains(detectorName).click({ force: true }); cy.waitForPageLoad('detector-details', { From eb8ee34e192a5f463a4bb4e35c30a78a0be573f4 Mon Sep 17 00:00:00 2001 From: Jovan Cvetkovic Date: Tue, 11 Apr 2023 20:09:16 +0200 Subject: [PATCH 7/7] Update detector details component #504 Signed-off-by: Jovan Cvetkovic --- .../DetectorBasicDetailsView.tsx | 83 ++++++------- .../DetectorBasicDetailsView.test.tsx.snap | 114 ++++++++++++++---- .../DetectorRulesView.test.tsx.snap | 2 +- .../UpdateAlertConditions.test.tsx.snap | 10 +- .../UpdateDetectorBasicDetails.test.tsx.snap | 14 +-- .../AlertTriggersView.test.tsx.snap | 6 +- .../DetectorDetails.test.tsx.snap | 71 ++++------- .../DetectorDetailsView.test.tsx.snap | 63 ++++------ .../__snapshots__/Detectors.test.tsx.snap | 4 +- .../EditFieldMappings.test.tsx.snap | 4 +- test/mocks/Alerts/PeriodSchedule.mock.ts | 2 +- 11 files changed, 196 insertions(+), 177 deletions(-) diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx index 4b7c67518..146ffd4a6 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/DetectorBasicDetailsView.tsx @@ -58,52 +58,43 @@ export const DetectorBasicDetailsView: React.FC = } > - {createTextDetailsGroup( - [ - { label: 'Detector name', content: name }, - { - label: 'Description', - content: inputs[0].detector_input.description || DEFAULT_EMPTY_DATA, - }, - { label: 'Detector schedule', content: detectorSchedule }, - ], - 4 - )} - {createTextDetailsGroup( - [ - { - label: 'Data source', - content: ( - <> - {inputs[0].detector_input.indices.map((ind: string) => ( - {ind} - ))} - - ), - }, - { label: 'Log type', content: detector_type.toLowerCase() }, - { - label: 'Detector dashboard', - content: (dashboardId ? ( - window.open(`dashboards#/view/${dashboardId}`, '_blank')}> - {`${name} summary`} - - - ) : ( - 'Not available for this log type' - )) as any, - }, - ], - 4 - )} - {createTextDetailsGroup( - [ - { label: 'Detection rules', content: totalSelected }, - { label: 'Created at', content: createdAt || DEFAULT_EMPTY_DATA }, - { label: 'Last updated time', content: lastUpdated || DEFAULT_EMPTY_DATA }, - ], - 4 - )} + {createTextDetailsGroup([ + { label: 'Detector name', content: name }, + { + label: 'Description', + content: inputs[0].detector_input.description || DEFAULT_EMPTY_DATA, + }, + { label: 'Detector schedule', content: detectorSchedule }, + ])} + {createTextDetailsGroup([ + { + label: 'Data source', + content: ( + <> + {inputs[0].detector_input.indices.map((ind: string) => ( + {ind} + ))} + + ), + }, + { label: 'Log type', content: detector_type.toLowerCase() }, + { + label: 'Detector dashboard', + content: (dashboardId ? ( + window.open(`dashboards#/view/${dashboardId}`, '_blank')}> + {`${name} summary`} + + + ) : ( + 'Not available for this log type' + )) as any, + }, + ])} + {createTextDetailsGroup([ + { label: 'Detection rules', content: totalSelected }, + { label: 'Created at', content: createdAt || DEFAULT_EMPTY_DATA }, + { label: 'Last updated time', content: lastUpdated || DEFAULT_EMPTY_DATA }, + ])} {rulesCanFold ? children : null} ); diff --git a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap index 87b3add5a..d91290cfb 100644 --- a/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap +++ b/public/pages/Detectors/components/DetectorBasicDetailsView/__snapshots__/DetectorBasicDetailsView.test.tsx.snap @@ -181,7 +181,7 @@ Object { class="euiSpacer euiSpacer--xl" />
- Not available for this log type +
+ .windows +
+
+
+ + +
+
+
+ +
+
+
+ detector_type
- -
-
@@ -271,7 +306,7 @@ Object { class="euiSpacer euiSpacer--xl" />
- Every 1 minute + 2
@@ -572,7 +607,7 @@ Object { class="euiSpacer euiSpacer--xl" />
- Not available for this log type +
+ .windows +
+
+
+
+
+
+
+
+ +
+
+
+ detector_type
- -
-
@@ -662,7 +732,7 @@ Object { class="euiSpacer euiSpacer--xl" />
- Every 1 minute + 2
diff --git a/public/pages/Detectors/components/DetectorRulesView/__snapshots__/DetectorRulesView.test.tsx.snap b/public/pages/Detectors/components/DetectorRulesView/__snapshots__/DetectorRulesView.test.tsx.snap index 3f059e572..1c68baff9 100644 --- a/public/pages/Detectors/components/DetectorRulesView/__snapshots__/DetectorRulesView.test.tsx.snap +++ b/public/pages/Detectors/components/DetectorRulesView/__snapshots__/DetectorRulesView.test.tsx.snap @@ -60,7 +60,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ diff --git a/public/pages/Detectors/components/UpdateAlertConditions/__snapshots__/UpdateAlertConditions.test.tsx.snap b/public/pages/Detectors/components/UpdateAlertConditions/__snapshots__/UpdateAlertConditions.test.tsx.snap index 735f7d5f9..78bd34098 100644 --- a/public/pages/Detectors/components/UpdateAlertConditions/__snapshots__/UpdateAlertConditions.test.tsx.snap +++ b/public/pages/Detectors/components/UpdateAlertConditions/__snapshots__/UpdateAlertConditions.test.tsx.snap @@ -65,7 +65,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -267,7 +267,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -492,7 +492,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -673,7 +673,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -877,7 +877,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ diff --git a/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap b/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap index 544a33e24..5c9c692f6 100644 --- a/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap +++ b/public/pages/Detectors/components/UpdateBasicDetails/__snapshots__/UpdateDetectorBasicDetails.test.tsx.snap @@ -65,7 +65,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -262,7 +262,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -437,7 +437,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -989,7 +989,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -1240,7 +1240,7 @@ exports[` spec renders the component 1`] = ` "schedule": Object { "period": Object { "interval": 1, - "unit": "minute", + "unit": "MINUTES", }, }, "triggers": Array [ @@ -1521,7 +1521,7 @@ exports[` spec renders the component 1`] = ` }, ] } - value="minute" + value="MINUTES" > spec renders the component 1`] = ` data-test-subj="detector-schedule-unit-select" onChange={[Function]} onMouseUp={[Function]} - value="minute" + value="MINUTES" >