diff --git a/public/pages/Findings/components/FindingDetailsFlyout.tsx b/public/pages/Findings/components/FindingDetailsFlyout.tsx index 9695c6ac..46030a42 100644 --- a/public/pages/Findings/components/FindingDetailsFlyout.tsx +++ b/public/pages/Findings/components/FindingDetailsFlyout.tsx @@ -234,79 +234,88 @@ export default class FindingDetailsFlyout extends Component< this.setState({ ...this.state, ruleViewerFlyoutData: null }); }; + shouldRenderRule = ({ id }: Query) => { + const { allRules = {} } = this.state; + const isSigmaRule = !!allRules[id]; + + if (!isSigmaRule) { + return false; + } + + return !isThreatIntelQuery(id); + }; + renderRuleDetails = (rules: Query[] = []) => { const { allRules = {} } = this.state; - return rules - .filter(({ id }) => !isThreatIntelQuery(id)) - .map((rule, key) => { - const fullRule = allRules[rule.id]; - const severity = capitalizeFirstLetter(fullRule.level); - return ( -
- - {fullRule.title} - - Severity: {severity} - -
- } - initialIsOpen={rules.length === 1} - data-test-subj={`finding-details-flyout-rule-accordion-${key}`} - > - - - - - this.showRuleDetails(fullRule, rule.id)} - data-test-subj={`finding-details-flyout-${fullRule.title}-details`} - > - {fullRule.title || DEFAULT_EMPTY_DATA} - - - - - - - {severity || DEFAULT_EMPTY_DATA} - - - - - { + const fullRule = allRules[rule.id]; + const severity = capitalizeFirstLetter(fullRule.level); + return ( +
+ + {fullRule.title} + + Severity: {severity} + +
+ } + initialIsOpen={rules.length === 1} + data-test-subj={`finding-details-flyout-rule-accordion-${key}`} + > + + + + + this.showRuleDetails(fullRule, rule.id)} + data-test-subj={`finding-details-flyout-${fullRule.title}-details`} > - {getLogTypeLabel(fullRule.category) || DEFAULT_EMPTY_DATA} - - - - - - {fullRule.description || DEFAULT_EMPTY_DATA} - - - - - - {this.renderTags(rule.tags) || DEFAULT_EMPTY_DATA} - - - - {rules.length > 1 && } - - ); - }); + {fullRule.title || DEFAULT_EMPTY_DATA} + +
+
+ + + + {severity || DEFAULT_EMPTY_DATA} + + + + + + {getLogTypeLabel(fullRule.category) || DEFAULT_EMPTY_DATA} + + +
+ + + {fullRule.description || DEFAULT_EMPTY_DATA} + + + + + + {this.renderTags(rule.tags) || DEFAULT_EMPTY_DATA} + +
+ + {rules.length > 1 && } + + ); + }); }; getIndexPatternId = async () => {