Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OuiDataGrid to emit custom events or callbacks when it goes into fullscreen mode #993

Closed
ananzh opened this issue Aug 25, 2023 · 0 comments · Fixed by #1053
Closed
Labels
enhancement New feature or request

Comments

@ananzh
Copy link
Member

ananzh commented Aug 25, 2023

Is your feature request related to a problem? Please describe.
Currently we see this in Discover 2.0 implementation, where full screen view is hiding under the nav:
image (9)

Here is the detailed investigation opensearch-project/OpenSearch-Dashboards#4824 (comment)

Describe the solution you'd like
When user clicks Full screen, only OuiDataGrid catch it. We won’t be able to catch the click in our application in OpenSearch Dashboards. We want a way to listen to or detect when the grid goes into fullscreen mode. Then by detecting full screen mode and have some property like showTopNavMenu to update TopNavMenu config, like

   <TopNavMenu
      .. other property
      config={showTopNavMenu ? topNavMenu : undefined}
    />`

Maybe consider extending or wrapping the OuiDataGrid component to emit custom events or callbacks when the fullscreen state changes.

Describe alternatives you've considered

We have tried several options but that ideal. Pls see the detailed investigation opensearch-project/OpenSearch-Dashboards#4824 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants