Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Docs) Badge #94

Closed
1 of 9 tasks
Tracked by #112
KrooshalUX opened this issue Oct 21, 2022 · 3 comments · Fixed by #338
Closed
1 of 9 tasks
Tracked by #112

(OUI Docs) Badge #94

KrooshalUX opened this issue Oct 21, 2022 · 3 comments · Fixed by #338
Assignees
Labels

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Oct 21, 2022

Section: Badge groups and truncation

  • Fix typo "only every be a single line of text" to "only ever be a single line of text"

Section: Beta badge type

  • Replace with OuiExperimentalBadge content
  • Replace beaker icon tooltips from "lab" to "experimental"
  • Replace "lab" with "experimental" in the line "beta badges will also line up nicely with titles"

Section - clickable beta badges:

@BSFishy
Copy link
Contributor

BSFishy commented Oct 26, 2022

Beta badge alignment can be modified by changing the vertical-align property here:

vertical-align: super; // if displayed inline with text

I've found that a value of text-bottom aligns with titles better.


To include a tooltip in the "lab" type (I'm assuming this is referring to the beta badge with a beaker icon), the tooltipContent attribute needs to be included, as shown here:

<OuiBetaBadge
label="Beta"
color={item}
tooltipContent="This module is not GA. Please help us by reporting any bugs."
/>

Currently, the lab icons in the docs don't have that attribute, but it's a quick fix:

<OuiBetaBadge label="Lab" color={item} iconType="beaker" />
&emsp;
<OuiBetaBadge label="Lab" size="s" color={item} iconType="beaker" />

@BSFishy
Copy link
Contributor

BSFishy commented Oct 28, 2022

Additionally, the clickable beta badge that says BASIC currently links to an Elastic page, that we should change.

@KrooshalUX
Copy link
Contributor Author

@BSFishy yes, for clarity these tasks for docs are in addition to removing elastic references. The elastic reference task is tracked as a launch requirement. These are iterative, rolling changes.

@KrooshalUX KrooshalUX moved this to Icebox (No Dev) in OUI Components Nov 1, 2022
@KrooshalUX KrooshalUX removed their assignment Dec 29, 2022
@AbhishekReddy1127 AbhishekReddy1127 self-assigned this Feb 11, 2023
@joshuarrrr joshuarrrr linked a pull request Feb 21, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Icebox : Do Not Action to Done in OUI Components Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants